Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect config.ssh.insert_key #328

Merged
merged 3 commits into from
May 22, 2017

Conversation

akitada
Copy link
Contributor

@akitada akitada commented May 4, 2017

Skip generating a keypair when config.ssh.insert_key is false.

  • Update README.md
  • Allow config.ssh.private_key_path only configuration (without keypair_name or public_key_path)
  • Add tests

@coveralls
Copy link

coveralls commented May 4, 2017

Coverage Status

Coverage decreased (-0.1%) to 87.483% when pulling 1206c16 on akitada:respect-insert-key into 34cb4cb on ggiamarchi:master.

@coveralls
Copy link

coveralls commented May 6, 2017

Coverage Status

Coverage increased (+0.02%) to 87.617% when pulling 47887c9 on akitada:respect-insert-key into 34cb4cb on ggiamarchi:master.

@coveralls
Copy link

coveralls commented May 6, 2017

Coverage Status

Coverage increased (+0.02%) to 87.617% when pulling f133db6 on akitada:respect-insert-key into 34cb4cb on ggiamarchi:master.

@coveralls
Copy link

coveralls commented May 6, 2017

Coverage Status

Coverage increased (+0.02%) to 87.617% when pulling 3959594 on akitada:respect-insert-key into 34cb4cb on ggiamarchi:master.

@akitada
Copy link
Contributor Author

akitada commented May 6, 2017

@ggiamarchi @julienvey
This patch completes #54. I would appreciate your review.

@coveralls
Copy link

coveralls commented May 13, 2017

Coverage Status

Coverage decreased (-0.5%) to 87.094% when pulling 76558bb on akitada:respect-insert-key into 34cb4cb on ggiamarchi:master.

@coveralls
Copy link

coveralls commented May 13, 2017

Coverage Status

Coverage decreased (-0.3%) to 87.272% when pulling 6d43d9f on akitada:respect-insert-key into 34cb4cb on ggiamarchi:master.

@coveralls
Copy link

coveralls commented May 13, 2017

Coverage Status

Coverage increased (+0.03%) to 87.628% when pulling 7a73359 on akitada:respect-insert-key into 34cb4cb on ggiamarchi:master.

@coveralls
Copy link

coveralls commented May 13, 2017

Coverage Status

Coverage increased (+0.03%) to 87.628% when pulling e4709cf on akitada:respect-insert-key into 34cb4cb on ggiamarchi:master.

@coveralls
Copy link

coveralls commented May 14, 2017

Coverage Status

Coverage decreased (-0.7%) to 86.356% when pulling e0543b1 on akitada:respect-insert-key into 2978da1 on ggiamarchi:master.

@coveralls
Copy link

coveralls commented May 14, 2017

Coverage Status

Coverage decreased (-0.7%) to 86.356% when pulling c778e08 on akitada:respect-insert-key into 2978da1 on ggiamarchi:master.

@coveralls
Copy link

coveralls commented May 14, 2017

Coverage Status

Coverage increased (+0.03%) to 87.06% when pulling e4fa083 on akitada:respect-insert-key into 2978da1 on ggiamarchi:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 87.016% when pulling 692b845 on akitada:respect-insert-key into 2978da1 on ggiamarchi:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 87.06% when pulling 692b845 on akitada:respect-insert-key into 2978da1 on ggiamarchi:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 87.06% when pulling 692b845 on akitada:respect-insert-key into 2978da1 on ggiamarchi:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 87.06% when pulling 692b845 on akitada:respect-insert-key into 2978da1 on ggiamarchi:master.

Skip generating a keypair when config.ssh.insert_key is false.
@coveralls
Copy link

coveralls commented May 14, 2017

Coverage Status

Coverage increased (+0.03%) to 87.06% when pulling 09e04f3 on akitada:respect-insert-key into 2978da1 on ggiamarchi:master.

@akitada
Copy link
Contributor Author

akitada commented May 14, 2017

Sorry for noise. The patch is ready for review this time.

@ggiamarchi
Copy link
Owner

@akitada No problem at all! At a first sight, it looks to be a good job. I'll test and review soon.

@ggiamarchi ggiamarchi merged commit b424746 into ggiamarchi:master May 22, 2017
@ggiamarchi
Copy link
Owner

@akitada Good one!

@akitada akitada deleted the respect-insert-key branch May 22, 2017 13:44
@ggiamarchi ggiamarchi added this to the 0.11.0 milestone May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants