-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect config.ssh.insert_key #328
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akitada
force-pushed
the
respect-insert-key
branch
from
May 6, 2017 11:12
1206c16
to
47887c9
Compare
akitada
force-pushed
the
respect-insert-key
branch
from
May 6, 2017 11:47
47887c9
to
f133db6
Compare
akitada
force-pushed
the
respect-insert-key
branch
from
May 6, 2017 13:02
f133db6
to
3959594
Compare
@ggiamarchi @julienvey |
akitada
force-pushed
the
respect-insert-key
branch
from
May 13, 2017 16:16
76558bb
to
6d43d9f
Compare
akitada
force-pushed
the
respect-insert-key
branch
from
May 13, 2017 16:34
6d43d9f
to
7a73359
Compare
akitada
force-pushed
the
respect-insert-key
branch
from
May 14, 2017 16:34
e0543b1
to
c778e08
Compare
akitada
force-pushed
the
respect-insert-key
branch
from
May 14, 2017 17:00
c778e08
to
e4fa083
Compare
2 similar comments
Skip generating a keypair when config.ssh.insert_key is false.
akitada
force-pushed
the
respect-insert-key
branch
from
May 14, 2017 17:46
692b845
to
09e04f3
Compare
Sorry for noise. The patch is ready for review this time. |
@akitada No problem at all! At a first sight, it looks to be a good job. I'll test and review soon. |
@akitada Good one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip generating a keypair when config.ssh.insert_key is false.
README.md
config.ssh.private_key_path
only configuration (withoutkeypair_name
orpublic_key_path
)