Double-star in ignore glob patterns does not work

[tremby]

I have a rule /public/**/*.js in my .gitignore file, which means ignore any file ending in .js which is in /public or any subdirectory of /public. Ag is still giving results from such files.

[smathy]

Same for me in 0.26

[ggreer]

Yes, this requires some changes to the ignoring code to work correctly. I don't use double-stars in my gitignores, so I've kinda neglected it. Sorry. :(

Note: The "ignore" label is for issues with git/hg/ag-ignores. It doesn't mean I'm going to ignore the issue.

[smathy]

😆 re the explanation of the ignore tag, thanks for the clarification :)

[jasonkarns]

As noted in #594 (comment), this could be solved for git by using git status --ignored to get the ignore list rather than parsing .gitignore directly.

[decaff]

I wired up Jason's suggestion, here. Not tested on Unix. Works for me on Windows.

[talha131]

Any update on this issue?

[talha131]

I have added note about this issue in the wiki.

[tremby]

I just use git grep instead of this package and no longer have to worry about things like this.

[lilyball]

Are single asterisks not supported either? I'm trying a pattern like p/main/*/migrations and it's not actually ignoring anything.

[roblourens]

I know this is an old issue, but is it likely to ever be fixed? If it might be fixable via PR, can you give a pointer to where in the code this pattern matching happens?

[gavenkoa]

@kballard I reported bug: #1060

Adding leaning slash allows matches of path with asterisks...

For your case it is /p/main/*/migrations

[fabiospampinato]

It would be nice if this got fixed. I was quite disappointed to discover that even though the readme says It ignores file patterns from your .gitignore and .hgignore. that's not really the case :/.

Reading @decaff's published fix this doesn't seem too hard to implement.

@ggreer would you consider a PR for this?

[fmcgough]

This is making ag basically unusable for me, I use double-stars heavily in my .gitignore files. It seems to be a regression since (at least) version 0.31, as I discovered when upgrading to ubuntu 18.04 from 16.04. And as @fabiospampinato mentioned, it's misleading and frustrating to find that the readme is incorrect.

[talha131]

@fmcgough There is an alternate RipGrep which does not have this bug. Like me, you may want to migrate to it.

[cmdcolin]

Would definitely like this :) big fan of ag, my hands are trained on it!

[rugglcon]

This is similar for leading backslashes. In .NET projects, ag still searches through the bin folder even though it is specified in .gitignore as \bin/

[togakangaroo]

Just to throw up another use case:

**/node_modules/*

!src/server/app/node_modules/my-app

for allowing "mock modules". This rule makes ag search all node_modules, making it kind of useless

[togakangaroo]

Workaround:

new file   .ignore
@@ -0,0 +1 @@
+node_modules
\ No newline at end of file

[jbuck94]

using --path-to-ignore .gitignore with

/node_modules/*

in my .gitignore seems to work