Support for search-by-language

[novalis]

Not the world's finest C code, but does the job. Fixes #128

[novalis]

(actually, I just amended that commit because I realized I didn't need to specifically list the languages in options.c)

[novalis]

(er, please disregard; the previous commit was, unfortunately, correct)

[novalis]

OK, I think I'm done fixing bugs and adding features for now.

[aehlke]

How is this going? Any way I could help? This is the biggest thing keeping me from switching entirely over to ag from ack. Thanks!

[novalis]

Which part is the biggest thing? Search-by-language works on my branch, and there are a few other bugs fixed as well. It's just that my branch is slower because it actually correctly handles gitignores.

[aehlke]

I meant just being able to specify --py for example is a great asset of ack. I'll try your branch out, thanks. If the maintainer isn't up to it anymore perhaps the community could step up with its own canonical fork.

Sent from my iPhone

On Aug 2, 2013, at 4:39 PM, novalis notifications@github.com wrote:

Which part is the biggest thing? Search-by-language works on my branch, and there are a few other bugs fixed as well. It's just that my branch is slower because it actually correctly handles gitignores.

�
Reply to this email directly or view it on GitHub.

[derekleverenz]

I'd like to see this merged or this feature added otherwise. Or maybe change the brew formula to use this fork.

[ggreer]

Sorry for the neglect. I've been pretty busy. :(

I'm going to do a coding session on October 26th at 1900UTC (noon pacific, or in 18 hours). I'll do my best to add this feature then. I don't think I'll merge everything in this pull request though, since it changes quite a few behaviors. I am aware of the gitignore issue, but I think most users value speed over correctness in edge cases.

If you want to follow along and give feedback, go to https://floobits.com/r/ggreer/the_silver_searcher/ at the specified time.

[novalis]

Thanks for the amazing offer. If I get home in time, I will try to join you, but it is unlikely that I will make it home before 2000UTC.

I think the gitignore stuff could (and should) be done more efficiently with caching.

[derekleverenz]

Oh dang I wasn't able to do that. Thanks for the update though, that's great.

[ggreer]

That certainly won't be the last real-time coding session. If you let me know some times that work for you, I might be able to schedule the next one accordingly. I'm on the west coast, and I'm usually awake from 8AM-midnight. That's 1300-700UTC.

[brondsem]

Seems like #283 has implemented this?

[ggreer]

Sorry for neglecting your work, but the main feature in this PR (language options) has been around in ag for a while. The git behavior isn't perfect, but it's also improved. Considering the size of this PR and the number of conflicts, all I can do is close it and apologize. Sorry.