Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better ignores #355

Merged
merged 13 commits into from
Mar 19, 2014
Merged

Better ignores #355

merged 13 commits into from
Mar 19, 2014

Commits on Mar 18, 2014

  1. Declare these targets as phony. That way you can make test all day long.

    @ggreer
    ggreer committed Mar 18, 2014
    Configuration menu
    Copy the full SHA
    2f661cc View commit details
    Browse the repository at this point in the history

  2. Run ag closer to normal mode in testing.

    @ggreer
    ggreer committed Mar 18, 2014
    Configuration menu
    Copy the full SHA
    984a12c View commit details
    Browse the repository at this point in the history

  3. Add test for ignoring subdirectories.

    @ggreer
    ggreer committed Mar 18, 2014
    Configuration menu
    Copy the full SHA
    66237c9 View commit details
    Browse the repository at this point in the history

  4. Braces.

    @ggreer
    ggreer committed Mar 18, 2014
    Configuration menu
    Copy the full SHA
    c7528ed View commit details
    Browse the repository at this point in the history

  5. Fix tiny memory leak. Only strlen(base_path) once. Make patterns that… 

    … start with ./ behave just like those that start with /.
    @ggreer
    ggreer committed Mar 18, 2014
    Configuration menu
    Copy the full SHA
    ddd5afe View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2014

  1. Slightly better test name. There will be more tests for ignores.

    @ggreer
    ggreer committed Mar 19, 2014
    Configuration menu
    Copy the full SHA
    68cbf81 View commit details
    Browse the repository at this point in the history

  2. ZERO AND ZERO IS ZERO

    @ggreer
    ggreer committed Mar 19, 2014
    Configuration menu
    Copy the full SHA
    91a6a13 View commit details
    Browse the repository at this point in the history

  3. TODO

    @ggreer
    ggreer committed Mar 19, 2014
    Configuration menu
    Copy the full SHA
    ffc9823 View commit details
    Browse the repository at this point in the history

  4. Don't call filename_ignore_search twice with the same filename.

    @ggreer
    ggreer committed Mar 19, 2014
    Configuration menu
    Copy the full SHA
    e8b7dd3 View commit details
    Browse the repository at this point in the history

  5. Meh. Don't use strcmp.

    @ggreer
    ggreer committed Mar 19, 2014
    Configuration menu
    Copy the full SHA
    a6c2328 View commit details
    Browse the repository at this point in the history

  6. Re-work ignoring. This should be faster and more accurate.

    @ggreer
    ggreer committed Mar 19, 2014
    Configuration menu
    Copy the full SHA
    2cc28cc View commit details
    Browse the repository at this point in the history

  7. Don't call filename_filter recursively. TODOs and cleanup.

    @ggreer
    ggreer committed Mar 19, 2014
    Configuration menu
    Copy the full SHA
    8309b34 View commit details
    Browse the repository at this point in the history

  8. Add failing test for ignore rules. We'll have to write our own fnmatc… 

    …h to fix this.
    @ggreer
    ggreer committed Mar 19, 2014
    Configuration menu
    Copy the full SHA
    e217bf7 View commit details
    Browse the repository at this point in the history