Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coveralls.io functionality. #72

Open
wants to merge 1 commit into
base: upstream
Choose a base branch
from

Conversation

Gusgus01
Copy link
Contributor

As mentioned in: #58

Before we merge this in, @StoicLoofah can you create a coveralls.io account and make sure that your level of access allows you to enable it for this repo?

If you do, it should show up under the repo tab with a switch to turn it on, then we can do the next steps and merge this commit.

It should provide a repo_token on the details page, that repo_token needs to be added to the circleci workflow as an environment variable.
COVERALLS_REPO_TOKEN = xxxxxxxxx
This can be achieved via the circleci dashboard by editing the workflow (gear next to the workflow name) then going to the Environment Variables tab.

The coveralls.io page also provides a nice embeddable

(I also removed the travis-ci configuration file, since I don't think it's used anymore)
I have tested this by creating accounts and doing it for my fork.
Gusgus01#3

@Gusgus01
Copy link
Contributor Author

The COVERALLS_REPO_TOKEN is needed because it looks like their integrations with circle ci is not the best implemented and has had issues for a long time, travis ci has integration such that the repo is found automatically:
lemurheavy/coveralls-public#1018

@StoicLoofah
Copy link
Collaborator

@Gusgus01 cool thanks for looking into this! I have the env var set in circleci. let me know if there's anything other config i need to do

image

@Gusgus01
Copy link
Contributor Author

I think that was the only config changes I had to make.

@StoicLoofah
Copy link
Collaborator

Is there a way to test that it works before I merge it in? will it work if you just make another commit onto this branch?

@Gusgus01
Copy link
Contributor Author

Circleci was using the account I made to test instead of ggtracker. Interesting.

I removed them and now it's using the ggtracker/sc2reader workflows. But it's failing with the error saying coveralls can't find the repo. That is the error I ran into when my COVERALLS_REPO_TOKEN was missing or incorrect.

@StoicLoofah
Copy link
Collaborator

Hmm, I'm not sure what's up with this. I have been trying to regenerate the token and flipping the env variable, but it isn't working. I'm pretty certain that the COVERALLS_REPO_TOKEN is in there correctly, though it also says it isn't necessary for private repos https://docs.coveralls.io/supported-ci-services

One possible issue is that I'm not actually a member of the ggtracker organization: I just have access to this one repo. @dsjoerg would you mind adding me to see if that fixes it?

@Gusgus01
Copy link
Contributor Author

Gusgus01 commented Dec 1, 2018

Under the section that says: CIRCLE, JENKINS, SEMAPHORE AND CODESHIP it says it needs the COVERALLS_REPO_TOKEN. Although I believe I saw in an issue on their repo, that they supposedly support auto-detection with CircleCI. But the issue I linked upthread also shows that they seem to have issues with it.

I wasn't too enthralled with coveralls.io, they seem to be lacking documentation. They also don't seem to engage very much on their issue tracker.

I was just doing it since it was an open issue, I usually track test coverage just using coverage on my dev environments :)

@cclauss
Copy link
Collaborator

cclauss commented Dec 29, 2023

This branch has git conflicts that must be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants