[kernel] Update syscall buffer verify FAULT to show bad address #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'll debug zlib and try to find what is going on. Already removed the "return 0" before the address check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more verbose error message to FAULT output when large model programs pass a buffer that seemingly does not belong to the process address space. Discussed in #2200 (comment).
Also fixes unsaved CX register in OWC __divmod routine. The C library should be recompiled for Watcom using either "make owc" or ./buildc86.sh.
@rafael2k: It would be worth a try to remove the "return 0" hack in verfy_area and then rerun gzip after recompiling the OW C library. This will then give better output as to what is happening with gzip, especially if run with strace.