-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: force to generate for non-required fields #91
Conversation
"__internal__": {"List": List, "Union": Union, "Tuple": Tuple}, | ||
}, | ||
initial_state: Dict[str, Any] = {}, | ||
context: Dict[str, Any] = MappingProxyType( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature to force non required fields is something that I was also looking for, would you have an ETA to release this? |
@ghandic could you check this? Would really like to have this feature available included. |
Hey, I've added feedback to the PR, would like to keep the Lorem strings and also have the allow_none_optionals be a float [0-1] which sets the probability for none to be provided as optionals |
Ey @ghandic. I cannot see any feedback in the PR. Anyway:
|
@ghandic the |
@ghandic changes applied. |
Overall looking good, I'll work on another PR to spice up the lorem a little bit after this is merged |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 99.19% 99.21% +0.02%
==========================================
Files 31 31
Lines 1116 1148 +32
==========================================
+ Hits 1107 1139 +32
Misses 9 9 ☔ View full report in Codecov by Sentry. |
Changes:
strings
of any length. If the generated string ends with a space, it will be changed to a dot (eg. 'at.' instead of 'at '. Just to avoid confusion.0.0
and1.0
, indicating the probability of allowing getting aNone
value.0.0
means "0% chances of getting aNone
",1.0
means "100% chances of getting aNone
",0.5
means "50% chances of getting aNone
", etc. The default is0.5
.