Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular Expressions and Template Expressions Refactor #54

Closed
9 tasks done
ghaschel opened this issue Sep 13, 2022 · 0 comments
Closed
9 tasks done

Angular Expressions and Template Expressions Refactor #54

ghaschel opened this issue Sep 13, 2022 · 0 comments
Assignees
Labels
refactor feature refactor

Comments

@ghaschel
Copy link
Owner

ghaschel commented Sep 13, 2022

Rewrite and update the typescript base patterns for Angular Expressions and Template Expressions Pattern Matching:

  • Working as before
    • Angular Expressions and Template expressions
      • Supporting non-null assertion operator (property!.value)
      • Supporting safe-navigation operator (property?.value)
      • Supporting nullish coalescing operator (condition ?? value)
      • Not breaking the highlighting when a ";" is not added before the HTML element attribute closing quote
    • String interpolation
      • class="card {{anotherClass}}
      • class="card {{condition ? 'rounded' : 'squared'}}"
@ghaschel ghaschel added the refactor feature refactor label Sep 13, 2022
@ghaschel ghaschel self-assigned this Sep 13, 2022
ghaschel added a commit that referenced this issue Sep 13, 2022
there are a bunch of changes being made, and it will be listed as related issues with the current
milestone

BREAKING CHANGE: the whole grammar is changing

re #55, re #54, re #53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor feature refactor
Projects
None yet
Development

No branches or pull requests

1 participant