Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template syntax highlighting no longer works since v2.0.0 #72

Closed
benjamin-achouche opened this issue Nov 8, 2022 · 5 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@benjamin-achouche
Copy link

benjamin-achouche commented Nov 8, 2022

Hi,

I noticed that this morning, syntax highlighting in my project was gone. I can only assume it's because of the last update that was applied on 07/11/22.

image

Can you help ?

Thanks !

EDIT: Apparently I was wrong, because when I rollback to previous versions up until 2.0.0, it still doesn't work. 1.8.4 does though. Maybe I just didn't notice up until now somehow ?

Anyway, it doesn't work for me from v2.0.0 on.

@benjamin-achouche benjamin-achouche added the bug Something isn't working label Nov 8, 2022
@benjamin-achouche benjamin-achouche changed the title Template syntax highlighting no longer works since last update (07/11/22) Template syntax highlighting no longer works since v2.0.0 Nov 8, 2022
@ghaschel
Copy link
Owner

ghaschel commented Nov 8, 2022

Please. run the "vscode-angular-html: Set legacy color customizations" command.

The extra-matched elements are no longer the default highlighting, but now, not only, the extra-matched characters works properly in different themes, but you can also customize your extra-matched characters via extension settings. Please, check the readme and the F.A.Q. for any references.

Let me know if running the command works for you. Thank you :)

@ghost
Copy link

ghost commented Nov 10, 2022

Please. run the "vscode-angular-html: Set legacy color customizations" command.
Let me know if running the command works for you. Thank you :)

I had the same problem and it was showing me this
Screenshot 2022-11-10 at 10 39 25

every time I changed a setting and not applying changes, but your command applies the changes.

While it works, I guess you should review this issue.

And thank s for your work. This really helps making code easier to read ;)

@ghaschel
Copy link
Owner

That's a bug, just confirmed myself.

Thank you for reporting it. I'll fix it soon.

@ghaschel
Copy link
Owner

This was fixed in v2.2.2.

@ghost
Copy link

ghost commented Nov 14, 2022

Just tested it, works great. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants