Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I had found two errors #126

Open
sdiebel opened this issue Nov 16, 2019 · 2 comments
Open

I had found two errors #126

sdiebel opened this issue Nov 16, 2019 · 2 comments

Comments

@sdiebel
Copy link

sdiebel commented Nov 16, 2019

PHP 7.3.1 (windows cli)

websockets.php:
protected function connect($socket) {
$user = new $this->userClass(uniqid('u'), $socket, 1); // I had to add the third argument else E_FATAL

testwebsock.php
$echo = new echoServer("0.0.0.0","9000",2048); // Also 3rd argument missing else E_FATAL

Your server and client works very well. Nice work!

@adriano-pinaffo
Copy link

Ideally you should add default values for those constructors. I was going to add a pull request to fix that, but I saw there are already 2 PRs for that and nothing was merged. Maybe this project was abandoned?

@ghedipunk
Copy link
Owner

ghedipunk commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants