Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of the renderer option for maps #113

Closed
become-iron opened this issue Dec 3, 2018 · 10 comments
Closed

Removal of the renderer option for maps #113

become-iron opened this issue Dec 3, 2018 · 10 comments

Comments

@become-iron
Copy link
Contributor

become-iron commented Dec 3, 2018

According to release notes, the renderer option has been removed from the Map constructor in ol v5.0.0
So renderer option in vl-map component (link) doesn't make sense now. Or WebGLMap should be used if 'webgl' was passed as renderer property. But most likely it must be another component

@ghettovoice
Copy link
Owner

Thank @become-iron for the note.

I need to check if different map implementation in the openlayers now have significantly different public interface. If no may be it can be hidden in the vuelayers like it was before.
Or may be introduce new map components for each openlayers map (vl-map-canvas, vl-map-webgl) but
hold vl-map for backward compatibility

@become-iron
Copy link
Contributor Author

By the way, WebGL renderer supports not only point features now (openlayers/openlayers#5462). I mention it because of comment in code which proposes the opposite:

/**
* Renderer. By default, **Canvas** and **WebGL** renderers are tested for support in that order,
* and the first supported used. **Note** that the **Canvas** renderer fully supports vector data,
* but **WebGL** can only render **Point** geometries.
* @type {string|string[]}
* @default ['canvas', 'webgl']
*/

@ghettovoice
Copy link
Owner

Obviously this comment is outdated a bit.
I added it a long time ago, now it should be changed by the work on this issue.

ghettovoice added a commit that referenced this issue Dec 23, 2018
Update `renderer` option usage according to the new OpenLayers version:
re-create ol instance with Map or WebGLMap ctor.

#113
@stale
Copy link

stale bot commented May 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 5, 2019
@stale stale bot closed this as completed May 12, 2019
@become-iron
Copy link
Contributor Author

become-iron commented May 12, 2019

@ghettovoice I think it shouldn't be closed yet

@become-iron
Copy link
Contributor Author

@ghettovoice I think this one should be pinned as well

@ghettovoice
Copy link
Owner

Yep

@ghettovoice ghettovoice reopened this Mar 26, 2020
@stale stale bot removed the stale label Mar 26, 2020
ghettovoice added a commit that referenced this issue Mar 30, 2020
ghettovoice added a commit that referenced this issue Mar 30, 2020
@ghettovoice
Copy link
Owner

Done as renderer prop with watcher.
Possible values: 'canvas' (default), 'webgl'

@krizman
Copy link

krizman commented Nov 27, 2020

I have noticed renderer property was still present in v0.11.28 but has disappeared in latest v0.12.
This is probably because OL does not support it anymore.

Just wanted to point out that the current docs still have renderer property on map.vue.

@ghettovoice
Copy link
Owner

@krizman yep, I know. Current published documentation is still for v0.11.
Thanks for report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants