Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calling open() method multiple times should keep drop (re)open #33

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Mar 22, 2023

  • in the original ms-select, the body click was being triggered prior to the open() method but that is inversed in our new lib with vanilla JS, so in order to have the same lifecycle as the original, we can simply add a single CPU cycle delay. This delay arg could also be used by the users for other reasons
  • the open() method which this PR fixes is demoed in methods 05 demo

- in the original ms-select, the body click was being triggered prior to the open() method but that is inversed in our new lib with vanilla JS, so in order to have the same lifecycle as the original, we can simply add a single CPU cycle delay. This delay arg could also be used by the users for other reasons
@github-actions
Copy link

github-actions bot commented Mar 22, 2023

🎭 Playwright Summary - Success 🎉

Playwright Report

multiple-select-root@0.0.0 test:e2e:ci /home/runner/work/multiple-select-vanilla/multiple-select-vanilla
playwright test --config playwright/playwright.config.ts

Running 102 tests using 1 worker
················································································
······················
102 passed (2.6m)

@ghiscoding ghiscoding merged commit c36cf45 into main Mar 22, 2023
@ghiscoding ghiscoding deleted the bugfix/open-drop branch March 22, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant