Allow configuration of the number of max requests handled per puppet … #114
Conversation
|
In order to work around https://tickets.puppetlabs.com/browse/PUP-731 we require to be able to customise the number of requests handled per puppet master process invocation (to 1 per process). This change makes the value customisable. |
dfairhurst
force-pushed
the
feature/config_maxrequests
branch
from
d8eefea to
9776ae8
Compare
|
Any chance to get this merged? |
| @@ -3,8 +3,8 @@ | |||
|
|
|||
| PassengerUseGlobalQueue On | |||
|
|
|||
| # Recycle master processes after they service 1000 requests | |||
| PassengerMaxRequests 1000 | |||
| # Recycle master processes after they service <%= @passenger_max_requests %> requests | |||
There was a problem hiding this comment.
Would recommend changing to
# Recycle master processes after they service the number of requests specified by PassengerMaxRequests. Default is 1000.
Reasoning being that seeing default when debugging is nice.
dfairhurst
force-pushed
the
feature/config_maxrequests
branch
from
9776ae8 to
18787b5
Compare
|
Updated as suggested |
|
Apologies, one more thing I had previously forgotten. Each parameter is documented in the README. Could you please document this new parameter in the style of the others. |
dfairhurst
force-pushed
the
feature/config_maxrequests
branch
from
18787b5 to
3312b02
Compare
|
Well spotted - didn't think of that. README now updated |
|
@ghoneycutt is there anything else to be done, for this to get merged? |
|
Thank you!! Released in v2.18.0 |
|
Many thanks |
…master process