Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v3.0.0 - Transition to Puppet v4 #121

Merged
merged 2 commits into from
Nov 2, 2016
Merged

Release v3.0.0 - Transition to Puppet v4 #121

merged 2 commits into from
Nov 2, 2016

Conversation

ghoneycutt
Copy link
Owner

No description provided.

@ghoneycutt
Copy link
Owner Author

@Phil-Friderici @jeffmccune

Could you please look over this. It works functionally and has spec tests, though I'm curious if we should change any param names or other items before releasing as the next major version.

@Phil-Friderici
Copy link
Contributor

My idea would be to separate the client related settings from the server related ones. So I would vote for moving all settings for the [master] section into the server class.

We have started to use a specific module to manage puppetserver [1]. And use [2] to manage puppet.conf.

Btw: we had the issue that /tmp is mounted with NOEXEC. Therefore I have added a workaround [3] that might be interessting in our case as well.

[1] https://github.com/Phil-Friderici/puppet-module-puppetserver/
[2] https://github.com/propyless/puppet-module-puppet
[3] Phil-Friderici/puppet-module-puppetserver@161ff2e

@jeffmccune
Copy link

Overall, looks good to me. I like the typing. Similar to what Phil said, if we're going to rename parameters I would recommend updating is_master to is_puppetserver or something similar to reflect the change in Puppet4 from puppet master to puppetserver. I also recommend separating the agent and the server functionality into two separate modules in an effort to more easily track the changes to the agent and puppetserver respectively.

@ghoneycutt ghoneycutt force-pushed the switch_to_v4 branch 2 times, most recently from 1078d70 to cd9ada0 Compare November 2, 2016 00:35
@ghoneycutt ghoneycutt changed the title WIP - Release v3.0.0 - Transition to Puppet v4 Release v3.0.0 - Transition to Puppet v4 Nov 2, 2016
@ghoneycutt ghoneycutt force-pushed the switch_to_v4 branch 5 times, most recently from cd0e435 to 54c0311 Compare November 2, 2016 01:50
@ghoneycutt ghoneycutt merged commit f190efc into master Nov 2, 2016
@ghoneycutt ghoneycutt deleted the switch_to_v4 branch November 2, 2016 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants