Fixing unremoved cronjobs, Issue #41 #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| user => $cron_user, | ||
| hour => $cron_hour, | ||
| minute => $cron_minute, | ||
| } | ||
|
|
||
| if $run_method == 'cron' { |
There was a problem hiding this comment.
this would remove the conditional for the run method. Remember that we want to support running as an agent, instead of cron.
|
it's still there (line 78), but now case is used instead of if else case $run_method {
'service': {
|
|
it is failing travis - https://travis-ci.org/ghoneycutt/puppet-module-puppet/jobs/14197352 1) puppet::agent class puppet::agent Puppet agent cron at boot should contain Cron[puppet_agent_once_at_boot] with user => "root" and special => "reboot" Failure/Error: }) expected that the catalogue would contain Cron[puppet_agent_once_at_boot] |
|
Working on that at the moment… |
|
et voilà |
|
@Phil-Friderici sorry I didnt get this merged in a timely manner. Can you please rebase against master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changing $run_in_noop from 'true' to 'false' only the reboot job's comment gets deleted but not the job itself. Danger of unwanted additional cronjobs and unexpected behaviour (OP vs NOOP).
Fixes #41 and includes fix for #43 (in lines 114 & 135)