Add parameters for http_proxy and http_proxy_port #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ghoneycutt, would it be possible to review this PR when you have the time. Kind regards, |
| @@ -14,6 +14,8 @@ | |||
| $env = $::env, | |||
| $puppet_server = 'puppet', | |||
| $puppet_ca_server = 'UNSET', | |||
| $http_proxy_host = 'UNSET', | |||
There was a problem hiding this comment.
need to validate this with is_domain_name() and have corresponding tests for failure
|
After you make these changes, could you please rebase into one commit and then rebase against master so that I can merge it? Thanks! I appreciate all the word you are putting into this module. |
kytomaki
force-pushed
the
feature/http_proxy
branch
from
d49f3d2 to
8306387
Compare
|
Added some spec tests and rebased into one commit against the master. Cheers! |
kytomaki
force-pushed
the
feature/http_proxy
branch
from
8306387 to
ebcec8d
Compare
kytomaki
force-pushed
the
feature/http_proxy
branch
from
ebcec8d to
a056d90
Compare
ghoneycutt
added a commit
that referenced
this pull request
Oct 9, 2014
Add parameters for http_proxy and http_proxy_port
|
Awesome work! Released in v2.13.0 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows setting http_proxy_host and http_proxy_port in agent's puppet.conf