Add etckeeper hooks #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kytomaki, I could accept this code, but it needs to be disabled by default and have spec tests. Best regards, |
|
Hello @ghoneycutt The hooks are now disabled by default and have spec tests. Please let me know if they're sufficient. Cheers, |
| @@ -177,6 +185,24 @@ | |||
| mode => $config_mode, | |||
| } | |||
|
|
|||
| if ($etckeeper_hooks_bool) { | |||
| file { 'etckeeper_pre': | |||
| path => '/etc/puppet/etckeeper-commit-pre', | |||
There was a problem hiding this comment.
These paths for the pre & post commits should also be a variable with the defaults set to the path you are using now. You can validate those with validate_absolute_path().
|
This looks good! I'm going to merge after merging the master port code in PR #82 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another try. Sorry. It's been one head-desk of a day.
So the puppet's ubuntu packages create etc-keeper hooks which might come handy.