Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors #96

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Fix errors #96

merged 1 commit into from
Aug 3, 2023

Conversation

kenrap
Copy link
Contributor

@kenrap kenrap commented Aug 3, 2023 •
edited
Loading

I missed a few things during the refactors. The unit tests didn't catch this though, so I'll be more diligent to test my changes by running networkmgr next time.

@kenrap kenrap requested a review from a team as a code owner August 3, 2023 20:34
@kenrap kenrap changed the title Fix error Fix errors Aug 3, 2023
ericbsd
ericbsd approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@ericbsd ericbsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericbsd ericbsd merged commit 501a90e into ghostbsd:master Aug 3, 2023
@kenrap kenrap deleted the error-fix branch August 4, 2023 07:56
@ericbsd ericbsd added the feature New feature or request label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericbsd ericbsd ericbsd approved these changes

Assignees

@kenrap kenrap

Labels
feature New feature or request
Projects
Development Management
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenrap @ericbsd