getLinesWithFilters should not mutate the config given as argument

ghostery · Jun 14, 2019 · eba8190 · eba8190
1 parent 218d5b7
commit eba8190
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/src/lists.ts b/src/lists.ts
@@ -189,7 +189,7 @@ export function getLinesWithFilters(
   raw: string,
   config: Partial<Config> = new Config(),
 ): Set<string> {
-  config = new Config(Object.assign(config, { debug: true }));
+  config = new Config(Object.assign({}, config, { debug: true }));
 
   const {
     networkFilters,
@@ -210,9 +210,13 @@ export function getLinesWithFilters(
  * Given two versions of the same subscription (e.g.: EasyList) as a string,
  * generate a raw diff (i.e.: a list of lines added and lines removed).
  */
-export function generateDiff(prevRevision: string, newRevision: string): IRawDiff {
-  const prevRevisionLines: Set<string> = getLinesWithFilters(prevRevision);
-  const newRevisionLines: Set<string> = getLinesWithFilters(newRevision);
+export function generateDiff(
+  prevRevision: string,
+  newRevision: string,
+  config: Partial<Config> = new Config(),
+): IRawDiff {
+  const prevRevisionLines: Set<string> = getLinesWithFilters(prevRevision, config);
+  const newRevisionLines: Set<string> = getLinesWithFilters(newRevision, config);
 
   const added: string[] = [];
   const removed: string[] = [];