Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom styles being ignored for pure has filters #4506

Merged

Conversation

seia-soto
Copy link
Member

@seia-soto seia-soto commented Dec 9, 2024

fixes ghostery/broken-page-reports#1009

This PR addresses custom styles being ignored when pure has filters matched.

For example, a filter (domain.tld##body:has(something):style(overflow: auto !important)) will be body:has(something) { display: none !important; }.

@seia-soto seia-soto added the PR: Bug Fix 🐛 Increment patch version when merged label Dec 9, 2024
@seia-soto seia-soto requested a review from chrmod December 9, 2024 10:07
@seia-soto seia-soto self-assigned this Dec 9, 2024
@seia-soto seia-soto requested a review from remusao as a code owner December 9, 2024 10:07
packages/adblocker/src/engine/engine.ts Outdated Show resolved Hide resolved
@seia-soto seia-soto requested a review from chrmod December 9, 2024 10:34
@chrmod chrmod merged commit ad32b49 into ghostery:master Dec 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 Increment patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mediamarkt.nl
2 participants