Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vietnamese locale #1385

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Update vietnamese locale #1385

merged 2 commits into from
Dec 14, 2023

Conversation

tachibana-shin
Copy link
Contributor

@tachibana-shin tachibana-shin commented Nov 16, 2023

This pr updates vietnamese translations for mv3. I check the update by:

import { readFileSync } from "node:fs"

const en = JSON.parse(readFileSync("./en/messages.json", "utf8"))
const vi = JSON.parse(readFileSync("./vi/messages.json", "utf8"))

const diff = Object.fromEntries(
  Object.entries(en).filter(([key]) => !(key in vi))
)

console.log(diff)

@smalluban smalluban added the v10 label Nov 17, 2023
@smalluban smalluban changed the title [mv3]: Update locale vi Update vietnamese locale Nov 17, 2023
@chrmod
Copy link
Member

chrmod commented Nov 21, 2023

Hi @tachibana-shin - many thanks for the translations, those are much appreciated. Was thinking on a process to support you and other community members help us work on the translations. Can you please send me an email to chrmod ghostery.com so we discuss this further?

@tachibana-shin
Copy link
Contributor Author

Hi @tachibana-shin - many thanks for the translations, those are much appreciated. Was thinking on a process to support you and other community members help us work on the translations. Can you please send me an email to chrmod ghostery.com so we discuss this further?

I think a discussion on Discord is more open than using e-mail

@chrmod
Copy link
Member

chrmod commented Nov 22, 2023

@tachibana-shin I appreciate the consideration for a transparent communication. The reason I've suggested email is so we can communicate not in public as I was going to propose you access to our translation platform - Transifex. And as we never done this with open-source contributors like you, we simply wanted to test the setup in a one-on-one conversation. Also to give you access the that platform we will need your email address, that is also why email seemed more appropriate. Hope this clarifies everything :)

@tachibana-shin
Copy link
Contributor Author

@tachibana-shin I appreciate the consideration for a transparent communication. The reason I've suggested email is so we can communicate not in public as I was going to propose you access to our translation platform - Transifex. And as we never done this with open-source contributors like you, we simply wanted to test the setup in a one-on-one conversation. Also to give you access the that platform we will need your email address, that is also why email seemed more appropriate. Hope this clarifies everything :)

Oh ok. I sended email. Please check inbox 😊

@chrmod chrmod merged commit 34c056c into ghostery:main Dec 14, 2023
2 checks passed
@tachibana-shin tachibana-shin deleted the patch-1 branch December 15, 2023 09:17
@smalluban smalluban mentioned this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants