Skip to content
This repository has been archived by the owner on Jun 14, 2020. It is now read-only.

github-contribs is broken #172

Closed
lourot opened this issue Oct 12, 2018 · 3 comments
Closed

github-contribs is broken #172

lourot opened this issue Oct 12, 2018 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@lourot
Copy link
Member

lourot commented Oct 12, 2018

github-contribs's tests turned red yesterday, because the unofficial interface to discover pull-requests seems to have changed.

So the last time we know for sure that the interface hadn't changed yet is October 10th 9:38AM UTC.

We need to:

  • fix github-contribs and pin the latest version here in ghuser,
  • re-crawl the recent days of all users,
  • re-crawl completely all users created since October 10th 9:38AM UTC.
@lourot lourot added the bug Something isn't working label Oct 12, 2018
@lourot lourot self-assigned this Oct 12, 2018
@brillout
Copy link
Collaborator

brillout commented Oct 12, 2018

Seems like GitHub's UI doesn't rely on any fined grained pull request "html endpoint" anymore but instead fetches bigger HTML parts that include the PRs.

The good news is that we can get a list of PRs with graphql:

{
  user(login: AurelienLourot) {
     id,
     pullRequests(first:100) {
      edges {
        node {
          id,
          repository {
            id
            url
          }
        }
      }
    }
  }
}

I checked with my account and does seem to exhaustively list all PRs.

This endpoint is not enough though as we need repoS where I contributed without any PR but by having received write permissions from the owner.

I'll investigate more later.

@brillout brillout assigned brillout and unassigned lourot Oct 12, 2018
@brillout
Copy link
Collaborator

We don't know how to properly set the header to be able to get these bigger HTML parts. Plus the structure of these bigger HTML parts are very likely to change.

So we will use the graphql api to get the list of all pull requests.

@lourot
Copy link
Member Author

lourot commented Oct 13, 2018

I got the big HTML parsing working. Not the best solution but this unblocks us for the short-term. Updated todo-list:

  • fix github-contribs,
  • pin the latest version here in ghuser, // done on October 13th at 5:04PM UTC
  • re-crawl the recent days of all users,
  • re-crawl completely all users created since October 10th 9:38AM UTC.

@lourot lourot assigned lourot and unassigned brillout Oct 13, 2018
lourot added a commit to ghuser-io/github-contribs that referenced this issue Oct 13, 2018
lourot added a commit to ghuser-io/db that referenced this issue Oct 13, 2018
@lourot lourot closed this as completed Oct 16, 2018
lourot added a commit to ghuser-io/github-contribs that referenced this issue Oct 20, 2018
lourot added a commit to ghuser-io/db that referenced this issue Oct 20, 2018
lourot added a commit to ghuser-io/github-contribs that referenced this issue Nov 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants