Define Py_GIL_DISABLED macro on Windows #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@colesbury is it necessary to do this for all C extensions on Windows? Shouldn't cPython do it automatically? |
|
Opened pypa/setuptools#4662 since discussion on the linked cpython issue seemed to imply they believe it should be setuptools' job to handle it. |
python/cpython#111650 Signed-off-by: Cristi Vîjdea <cvijdea@bitdefender.com>
cvijdea-bd
force-pushed
the
windows-nogil
branch
from
b5e82ba
to
08ea7c8
Compare
Yes, I think so, at least for now.
That would be much better, but I think the way the Python Windows installer works makes that not possible. We should probably work on getting setuptools to define |
|
Thank you @colesbury and @cvijdea-bd! I am merging this then. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
python/cpython#111650
CPython doesn't ensure Py_GIL_DISABLED is defined when building against the free-threading interpreter, and setuptools doesn't either.
If it is not defined the resulting module will have the 313t abi tag but will crash on import due to linking to
python313.dllinstead ofpython313t.dll.