Apply helm3 changes #325
Merged
Apply helm3 changes #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomahawk28
reviewed
May 18, 2020
| github.com/giantswarm/e2esetup v0.2.0 | ||
| github.com/giantswarm/e2etemplates v0.2.0 | ||
| github.com/giantswarm/errors v0.2.3 | ||
| github.com/giantswarm/e2esetup v0.2.1-0.20200401192455-acfdbff0dabe |
There was a problem hiding this comment.
Do we have a problem with e2esetup 0.2.0? I saw chart-operator is using 0.1.0 currently.
There was a problem hiding this comment.
Yes good catch. It's because it's still using Helm 2. I think we need to create a 0.3.0 release with helmclient 1.0.0.
There was a problem hiding this comment.
I will follow up after we finished CP testing.
tomahawk28
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward giantswarm/giantswarm#10973
Checklist