This repository has been archived by the owner on May 7, 2024. It is now read-only.
Adapt 'gsctl create kubeconfig' to add support for v5 clusters #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuommaki
approved these changes
Oct 1, 2019
| apiEndpoint = fmt.Sprintf("https://%s.%s", tenantInternalAPIPrefix, strings.Join(baseEndpoint, urlDelimiter)) | ||
| } else { | ||
| apiEndpoint = clusterDetailsResponse.Payload.APIEndpoint | ||
| if result.apiEndpoint == "" { |
There was a problem hiding this comment.
Would it make sense to extract this to separate function and inline the call in if-case above? I find this logic a little difficult to follow, because first it works with V5, then if that fails it potentially just logs and next step is suddenly v4 call if some variable is unset so far.
I feel like these generated types require some wrapping so that the higher level business logic would be clean, but is a bit overkill at this point maybe.
There was a problem hiding this comment.
Changed the way cluster details are pulled.
tuommaki
reviewed
Oct 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/giantswarm/giantswarm/issues/6447, https://github.com/giantswarm/giantswarm/issues/5465
This PR changes the behaviour if the
gsctl create kubeconfigcommand-v/--verboseflag is applied, to make the output cleaner.Preview