Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

Enable Azure node pool autoscaler #602

Merged
merged 5 commits into from
Jan 12, 2021
Merged

Enable Azure node pool autoscaler #602

merged 5 commits into from
Jan 12, 2021

Conversation

axbarsan
Copy link
Contributor

@axbarsan axbarsan commented Dec 16, 2020

Towards https://github.com/giantswarm/giantswarm/issues/14795

This PR adds node pool autoscaling support for Azure.

@axbarsan axbarsan self-assigned this Dec 16, 2020
@axbarsan axbarsan requested a review from a team December 16, 2020 16:14
@axbarsan axbarsan marked this pull request as ready for review December 16, 2020 16:14
@axbarsan axbarsan changed the title Enable Azure autoscaler Enable Azure node pool autoscaler Dec 16, 2020
@coveralls
Copy link

coveralls commented Dec 16, 2020

Coverage Status

Coverage increased (+0.006%) to 51.361% when pulling f3a34d8 on add-azure-autoscaler into 90d5e28 on master.

@whites11
Copy link
Contributor

Untestable on germanywestcentral. See https://github.com/giantswarm/giantswarm/issues/14915

Copy link
Contributor

@tuommaki tuommaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

@axbarsan
Copy link
Contributor Author

Untestable on germanywestcentral. See giantswarm/giantswarm#14915

@whites11 it should work now 👍🏻

@whites11
Copy link
Contributor

Untestable on germanywestcentral. See giantswarm/giantswarm#14915

@whites11 it should work now 👍🏻

Tested and working perfectly, thanks a lot

@axbarsan axbarsan merged commit 1ffab2c into master Jan 12, 2021
@axbarsan axbarsan deleted the add-azure-autoscaler branch January 12, 2021 11:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
7 participants