Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add corev1.ConfigMap client functions and types #2348

Merged
merged 3 commits into from
Apr 14, 2021

Conversation

axbarsan
Copy link
Contributor

Towards https://github.com/giantswarm/giantswarm/issues/16717

This PR adds client-side types and functions for dealing with MAPI ConfigMap resources.

@axbarsan axbarsan added the kind/dev-change Changing a development operation label Apr 13, 2021
@axbarsan axbarsan requested review from a team April 13, 2021 16:12
@axbarsan axbarsan self-assigned this Apr 13, 2021
Copy link
Member

@kopiczko kopiczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane

apiVersion: 'v1';
kind: typeof ConfigMap;
metadata: metav1.IObjectMeta;
immutable?: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL CM has immutable field

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Starting from v1.19, you can add an immutable field to a ConfigMap definition to create an immutable ConfigMap.

https://kubernetes.io/docs/concepts/configuration/configmap/#configmap-immutable

src/model/services/mapi/corev1/createConfigMap.ts Outdated Show resolved Hide resolved
@axbarsan axbarsan merged commit ae9ce79 into master Apr 14, 2021
@axbarsan axbarsan deleted the create-configmap-client-functions branch April 14, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/dev-change Changing a development operation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants