This repository has been archived by the owner on Apr 12, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 422
Small changes for install chart on kebernetes 1.11 #113
Open
ozlevka-work
wants to merge
4
commits into
giantswarm:master
Choose a base branch
from
ozlevka-work:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
piVersion: v1 | ||
apiVersion: v1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. good catch |
||
kind: ServiceAccount | ||
metadata: | ||
labels: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
alertmanager: | ||
## If false, alertmanager will not be installed | ||
## | ||
enabled: true | ||
enabled: false | ||
|
||
## alertmanager container name | ||
## | ||
|
@@ -104,7 +104,7 @@ alertmanager: | |
## If true, alertmanager will create/use a Persistent Volume Claim | ||
## If false, use emptyDir | ||
## | ||
enabled: true | ||
enabled: false | ||
|
||
## alertmanager data Persistent Volume access modes | ||
## Must match those of existing PV or dynamic provisioner | ||
|
@@ -360,7 +360,7 @@ server: | |
## If true, Prometheus server will create/use a Persistent Volume Claim | ||
## If false, use emptyDir | ||
## | ||
enabled: true | ||
enabled: false | ||
|
||
## Prometheus server data Persistent Volume access modes | ||
## Must match those of existing PV or dynamic provisioner | ||
|
@@ -449,7 +449,7 @@ initChownData: | |
## If false, data ownership will not be reset at startup | ||
## This allows the prometheus-server to be run with an arbitrary user | ||
## | ||
enabled: true | ||
enabled: false | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't all of these be true? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah I would like to default everything to enable, you can always customize your values and use them in the installation command.
|
||
|
||
## initChownData container name | ||
## | ||
|
@@ -868,7 +868,7 @@ grafana: | |
affinity: {} | ||
|
||
adminUser: admin | ||
# adminPassword: strongpassword | ||
adminPassword: Ericom123$ | ||
ozlevka-work marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
## Use an alternate scheduler, e.g. "stork". | ||
## ref: https://kubernetes.io/docs/tasks/administer-cluster/configure-multiple-schedulers/ | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍