Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete go-test job #261

Merged
merged 8 commits into from
Dec 4, 2023
Merged

Remove obsolete go-test job #261

merged 8 commits into from
Dec 4, 2023

Conversation

marians
Copy link
Member

@marians marians commented Nov 29, 2023

go-test and go-build both run unit tests. This PR removes the redundant step to save cost and resources.

Checklist

  • Update changelog in CHANGELOG.md.

@marians marians self-assigned this Nov 29, 2023
@marians
Copy link
Member Author

marians commented Nov 29, 2023

FYI: branch protection rules must be adapted before merging this PR.

@marians marians marked this pull request as ready for review November 29, 2023 17:46
@marians marians requested a review from a team as a code owner November 29, 2023 17:46
@marians
Copy link
Member Author

marians commented Nov 30, 2023

Falling into a rabbit hole...

@marians
Copy link
Member Author

marians commented Nov 30, 2023

@fiunchinho Please take another look, since I had to change a lot more than I wanted, in order to go through the pipeline.

Copy link
Member

@fiunchinho fiunchinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@fiunchinho fiunchinho merged commit dab8c31 into master Dec 4, 2023
4 checks passed
@fiunchinho fiunchinho deleted the remove-go-test branch December 4, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants