Skip to content

Commit

Permalink
deps: cherry-pick b8331cc030 from upstream V8
Browse files Browse the repository at this point in the history
Original commit message:

    I believe the paths to the V8 include headers are incorrect. The
    paths to other sources seem to be relative to the parent directory.

    When building Node.js I get the following warning on Windows:
    Warning: Missing input files:
    deps\v8\src\..\..\include\v8-inspector-protocol.h
    deps\v8\src\..\..\include\v8-inspector.h

    This commit updates the two include paths.

    Bug:
    Change-Id: I51a057abba61e294e7811ba69db03e283b0bdc3f
    Reviewed-on: https://chromium-review.googlesource.com/743981
    Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{nodejs#49121}

This commit also increments the v8_embedder_string version.

PR-URL: nodejs#16900
Backport-PR-URL: nodejs#16413
Fixes: nodejs#16614
Refs: v8/v8@b8331cc
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
danbev authored and gibfahn committed Jan 16, 2018
1 parent 1d1975a commit 13fbfa4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions deps/v8/src/inspector/inspector.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
'inspector_all_sources': [
'<@(inspector_generated_sources)',
'<(inspector_generated_injected_script)',
'../../include/v8-inspector.h',
'../../include/v8-inspector-protocol.h',
'../include/v8-inspector.h',
'../include/v8-inspector-protocol.h',
'inspector/injected-script.cc',
'inspector/injected-script.h',
'inspector/inspected-context.cc',
Expand Down

0 comments on commit 13fbfa4

Please sign in to comment.