Skip to content

Commit

Permalink
Revert "Wait for DB writes to propagate (causality checks)"
Browse files Browse the repository at this point in the history
This reverts commit a5b0bf4.

The openstack-k8s-operators/mariadb-operator#229
switched the mariadb-operator to Active/Passive mode instead of
multimaster. This means we don't need to force synchronization from the
client config any more.
  • Loading branch information
gibizer committed Jun 14, 2024
1 parent e414db9 commit 728cd18
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
5 changes: 0 additions & 5 deletions templates/placementapi/config/placement.conf
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,6 @@ debug = true
[placement_database]
connection = {{ .DatabaseConnection }}

# Wait for writes to complete when doing a read.
# Relevant for multi-master galera deployments
# https://mariadb.com/docs/server/ref/mdb/system-variables/wsrep_sync_wait/
mysql_wsrep_sync_wait = 1

[api]
auth_strategy = keystone

Expand Down
1 change: 0 additions & 1 deletion tests/functional/placementapi_controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,6 @@ var _ = Describe("PlacementAPI controller", func() {
Expect(string(conf)).Should(
ContainSubstring(fmt.Sprintf("connection = mysql+pymysql://%s:%s@hostname-for-openstack.%s.svc/placement?read_default_file=/etc/my.cnf",
mariadbAccount.Spec.UserName, mariadbSecret.Data[mariadbv1.DatabasePasswordSelector], namespace)))
Expect(string(conf)).Should(ContainSubstring("mysql_wsrep_sync_wait = 1"))

custom := cm.Data["custom.conf"]
Expect(custom).Should(ContainSubstring("foo = bar"))
Expand Down

0 comments on commit 728cd18

Please sign in to comment.