fix: add gitignore

.ansible-lint

@@ -0,0 +1,14 @@
+offline: true
+exclude_paths:
+  - .github/
+  - dev/
+  - docs/
+  - venv
+  - playbooks/meta
+  - tdp_lib_dag
+  - galaxy.yml
+
+warn_list: []
+
+skip_list:
+  - yaml[octal-values]

.github/workflows/ansible-lint.yml

@@ -0,0 +1,26 @@
+name: Ansible Lint
+on:
+  pull_request:
+    types: [opened, reopened, synchronize]
+env:
+  NAMESPACE: tosit
+  COLLECTION_NAME: tdp_observability
+  ANSIBLE_COLLECTIONS_PATH: ${{ github.workspace }}
+jobs:
+  ansible-lint:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Check out TOSIT-IO/tdp-collection
+        uses: actions/checkout@v3
+        with:
+          repository: TOSIT-IO/tdp-collection
+          path: ansible_collections/${{env.NAMESPACE}}/tdp
+      - uses: actions/checkout@v3
+        with:
+          path: ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}}
+      - name: Setup venv for linting
+        run: dev/setup.sh
+        working-directory: ./ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}}
+      - name: Run ansible-lint
+        run: source venv/bin/activate && ansible-lint
+        working-directory: ./ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}}

.github/workflows/conventional-commits.yml

@@ -0,0 +1,10 @@
+name: Conventional Commits
+on:
+  pull_request:
+    types: [opened, reopened, synchronize]
+jobs:
+  check-conventional-commits:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: webiny/action-conventional-commits@v1.0.3

.github/workflows/license_check.yml

@@ -0,0 +1,11 @@
+name: Check License Headers
+on:
+  pull_request:
+    types: [opened, reopened, synchronize]
+jobs:
+  check-license-headers:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@master
+    - name: Check license headers
+      run: npx @kt3k/license-checker@3.2.2

.gitignore

@@ -1,2 +1,3 @@
 # Visual Studio Code
 .vscode
+venv

.licenserc.json

@@ -0,0 +1,10 @@
+{
+  "**/*.{py,yml,j2}": [
+    "# Copyright 2022 TOSIT.IO",
+    "# SPDX-License-Identifier: Apache-2.0"
+  ],
+  "ignore": [
+    ".github",
+    "venv"
+  ]
+}

dev/requirements.txt

@@ -0,0 +1,8 @@
+ansible-lint==6.17.2
+ansible-core==2.15.1
+jsonschema==4.18.0
+braceexpand==0.1.7
+termcolor==2.3.0
+gitPython==3.1.38
+passlib==1.7.4
+jmespath==1.0.1

dev/setup.sh

@@ -0,0 +1,32 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
+readonly PYTHON_BIN=${PYTHON_BIN:-python3}
+readonly PYTHON_VENV=${PYTHON_VENV:-venv}
+
+setup_python_venv() {
+  if [[ ! -d "$PYTHON_VENV" ]]; then
+    echo "Create python venv with '${PYTHON_BIN}' to '${PYTHON_VENV}' and update pip to latest version"
+    "$PYTHON_BIN" -m venv "$PYTHON_VENV"
+    (
+      source "${PYTHON_VENV}/bin/activate"
+      pip install -U pip
+    )
+  else
+    echo "Python venv '${PYTHON_VENV}' already exists, nothing to do"
+  fi
+  echo "Install python dependencies"
+  (
+    source "${PYTHON_VENV}/bin/activate"
+    pip install -r dev/requirements.txt
+    ansible-galaxy collection install community.general
+  )
+  return 0
+}
+
+main() {
+  setup_python_venv
+}
+
+main "$@"

playbooks/exporter_node_install.yml

@@ -2,13 +2,13 @@
 # SPDX-License-Identifier: Apache-2.0
 
 ---
-- name: node-exporter install
+- name: Node exporter install
   hosts: exporter_node
   tasks:
-    - tosit.tdp.resolve: # noqa unnamed-task
+    - tosit.tdp.resolve:                # noqa name[missing]
         node_name: exporter_node
     - name: Install node exporter
       ansible.builtin.import_role:
         name: tosit.tdp_observability.exporter.node
         tasks_from: install
-    - ansible.builtin.meta: clear_facts # noqa unnamed-task
+    - ansible.builtin.meta: clear_facts # noqa name[missing]

playbooks/exporter_node_restart.yml

@@ -2,13 +2,13 @@
 # SPDX-License-Identifier: Apache-2.0
 
 ---
-- name: node-exporter restart
+- name: Node exporter restart
   hosts: exporter_node
   tasks:
-    - tosit.tdp.resolve: # noqa unnamed-task
+    - tosit.tdp.resolve:                # noqa name[missing]
         node_name: exporter_node
     - name: Restart node exporter
       ansible.builtin.import_role:
         name: tosit.tdp_observability.exporter.node
         tasks_from: restart
-    - ansible.builtin.meta: clear_facts # noqa unnamed-task
+    - ansible.builtin.meta: clear_facts # noqa name[missing]

playbooks/exporter_node_start.yml

@@ -2,13 +2,13 @@
 # SPDX-License-Identifier: Apache-2.0
 
 ---
-- name: node-exporter start
+- name: Node exporter start
   hosts: exporter_node
   tasks:
-    - tosit.tdp.resolve: # noqa unnamed-task
+    - tosit.tdp.resolve:                # noqa name[missing]
         node_name: exporter_node
     - name: Start node exporter
       ansible.builtin.import_role:
         name: tosit.tdp_observability.exporter.node
         tasks_from: start
-    - ansible.builtin.meta: clear_facts # noqa unnamed-task
+    - ansible.builtin.meta: clear_facts # noqa name[missing]

playbooks/exporter_node_status.yml

@@ -2,13 +2,13 @@
 # SPDX-License-Identifier: Apache-2.0
 
 ---
-- name: node-exporter status
+- name: Node exporter status
   hosts: exporter_node
   tasks:
-    - tosit.tdp.resolve: # noqa unnamed-task
+    - tosit.tdp.resolve:                # noqa name[missing]
         node_name: exporter_node
-    - name: node exporter status
+    - name: Node exporter status
       ansible.builtin.import_role:
         name: tosit.tdp_observability.exporter.node
         tasks_from: status
-    - ansible.builtin.meta: clear_facts # noqa unnamed-task
+    - ansible.builtin.meta: clear_facts # noqa name[missing]

playbooks/exporter_node_stop.yml

@@ -2,13 +2,13 @@
 # SPDX-License-Identifier: Apache-2.0
 
 ---
-- name: node-exporter stop
+- name: Node exporter stop
   hosts: exporter_node
   tasks:
-    - tosit.tdp.resolve: # noqa unnamed-task
+    - tosit.tdp.resolve:                # noqa name[missing]
         node_name: exporter_node
     - name: Stop node exporter
       ansible.builtin.import_role:
         name: tosit.tdp_observability.exporter.node
         tasks_from: stop
-    - ansible.builtin.meta: clear_facts # noqa unnamed-task
+    - ansible.builtin.meta: clear_facts # noqa name[missing]

playbooks/exporter_postgres_install.yml

@@ -2,13 +2,13 @@
 # SPDX-License-Identifier: Apache-2.0
 
 ---
-- name: postgres-exporter install
+- name: Postgres exporter install
   hosts: exporter_postgres
   tasks:
-    - tosit.tdp.resolve: # noqa unnamed-task
+    - tosit.tdp.resolve:                # noqa name[missing]
         node_name: exporter_postgres
     - name: Install postgres exporter
       ansible.builtin.import_role:
         name: tosit.tdp_observability.exporter.postgres
         tasks_from: install
-    - ansible.builtin.meta: clear_facts # noqa unnamed-task
+    - ansible.builtin.meta: clear_facts # noqa name[missing]

playbooks/exporter_postgres_restart.yml

@@ -2,13 +2,13 @@
 # SPDX-License-Identifier: Apache-2.0
 
 ---
-- name: postgres-exporter restart
+- name: Postgres exporter restart
   hosts: exporter_postgres
   tasks:
-    - tosit.tdp.resolve: # noqa unnamed-task
+    - tosit.tdp.resolve:                # noqa name[missing]
         node_name: exporter_postgres
     - name: Restart postgres exporter
       ansible.builtin.import_role:
         name: tosit.tdp_observability.exporter.postgres
         tasks_from: restart
-    - ansible.builtin.meta: clear_facts # noqa unnamed-task
+    - ansible.builtin.meta: clear_facts # noqa name[missing]

playbooks/exporter_postgres_start.yml

@@ -2,13 +2,13 @@
 # SPDX-License-Identifier: Apache-2.0
 
 ---
-- name: postgres-exporter start
+- name: Postgres exporter start
   hosts: exporter_postgres
   tasks:
-    - tosit.tdp.resolve: # noqa unnamed-task
+    - tosit.tdp.resolve:                # noqa name[missing]
         node_name: exporter_postgres
     - name: Start postgres exporter
       ansible.builtin.import_role:
         name: tosit.tdp_observability.exporter.postgres
         tasks_from: start
-    - ansible.builtin.meta: clear_facts # noqa unnamed-task
+    - ansible.builtin.meta: clear_facts # noqa name[missing]

playbooks/exporter_postgres_status.yml

@@ -2,13 +2,13 @@
 # SPDX-License-Identifier: Apache-2.0
 
 ---
-- name: postgres-exporter status
+- name: Postgres exporter status
   hosts: exporter_postgres
   tasks:
-    - tosit.tdp.resolve: # noqa unnamed-task
+    - tosit.tdp.resolve:                # noqa name[missing]
         node_name: exporter_postgres
-    - name: postgres exporter status
+    - name: Postgres exporter status
       ansible.builtin.import_role:
         name: tosit.tdp_observability.exporter.postgres
         tasks_from: status
-    - ansible.builtin.meta: clear_facts # noqa unnamed-task
+    - ansible.builtin.meta: clear_facts # noqa name[missing]

playbooks/exporter_postgres_stop.yml

@@ -2,13 +2,13 @@
 # SPDX-License-Identifier: Apache-2.0
 
 ---
-- name: postgres-exporter stop
+- name: Postgres exporter stop
   hosts: exporter_postgres
   tasks:
-    - tosit.tdp.resolve: # noqa unnamed-task
+    - tosit.tdp.resolve:                # noqa name[missing]
         node_name: exporter_postgres
     - name: Stop postgres exporter
       ansible.builtin.import_role:
         name: tosit.tdp_observability.exporter.postgres
         tasks_from: stop
-    - ansible.builtin.meta: clear_facts # noqa unnamed-task
+    - ansible.builtin.meta: clear_facts # noqa name[missing]

playbooks/loki_server_config.yml

@@ -5,9 +5,10 @@
 - name: Loki server config
   hosts: loki
   tasks:
-    - tosit.tdp.resolve:
+    - tosit.tdp.resolve:                # noqa name[missing]
         node_name: loki_server
-    - ansible.builtin.import_role:
+    - name: Configure loki server
+      ansible.builtin.import_role:
         name: tosit.tdp_observability.loki.server
         tasks_from: config
-    - ansible.builtin.meta: clear_facts
+    - ansible.builtin.meta: clear_facts # noqa name[missing]

playbooks/loki_server_install.yml

@@ -5,9 +5,10 @@
 - name: Loki server install
   hosts: loki
   tasks:
-    - tosit.tdp.resolve:
+    - tosit.tdp.resolve:                # noqa name[missing]
         node_name: loki_server
-    - ansible.builtin.import_role:
+    - name: Install loki server
+      ansible.builtin.import_role:
         name: tosit.tdp_observability.loki.server
         tasks_from: install
-    - ansible.builtin.meta: clear_facts
+    - ansible.builtin.meta: clear_facts # noqa name[missing]

playbooks/loki_server_restart.yml

@@ -5,9 +5,10 @@
 - name: Loki server restart
   hosts: loki
   tasks:
-    - tosit.tdp.resolve:
+    - tosit.tdp.resolve:                # noqa name[missing]
         node_name: loki_server
-    - ansible.builtin.import_role:
+    - name: Restart loki server
+      ansible.builtin.import_role:
         name: tosit.tdp_observability.loki.server
         tasks_from: restart
-    - ansible.builtin.meta: clear_facts
+    - ansible.builtin.meta: clear_facts # noqa name[missing]

playbooks/loki_server_start.yml

@@ -5,9 +5,10 @@
 - name: Loki server start
   hosts: loki
   tasks:
-    - tosit.tdp.resolve:
+    - tosit.tdp.resolve:                # noqa name[missing]
         node_name: loki_server
-    - ansible.builtin.import_role:
+    - name: Start loki server
+      ansible.builtin.import_role:
         name: tosit.tdp_observability.loki.server
         tasks_from: start
-    - ansible.builtin.meta: clear_facts
+    - ansible.builtin.meta: clear_facts # noqa name[missing]

playbooks/loki_server_stop.yml

@@ -5,9 +5,10 @@
 - name: Loki server stop
   hosts: loki
   tasks:
-    - tosit.tdp.resolve:
+    - tosit.tdp.resolve:                # noqa name[missing]
         node_name: loki_server
-    - ansible.builtin.import_role:
+    - name: Stop loki server
+      ansible.builtin.import_role:
         name: tosit.tdp_observability.loki.server
         tasks_from: stop
-    - ansible.builtin.meta: clear_facts
+    - ansible.builtin.meta: clear_facts # noqa name[missing]

roles/exporter/node/handlers/main.yml

@@ -2,6 +2,7 @@
 # SPDX-License-Identifier: Apache-2.0
 
 ---
-- name: systemctl daemon-reload
+- name: Run systemctl daemon-reload
   ansible.builtin.systemd:
-    daemon_reload: yes
+    daemon_reload: true
+  listen: systemctl daemon-reload