custom client + parse macro + signature check functions

[JakubKoralewski]

Let me know what you think when you get the chance.

[JakubKoralewski]

Here's how I implemented a RequestBuilder for async:

struct AsyncRequestBuilder {
    inner: RequestBuilder
}

impl RequestBuildah for AsyncRequestBuilder {
    type Error = anyhow::Error;
    type ReturnValue = tokio::task::JoinHandle<anyhow::Result<String>>;

    fn new(method: Method, url: &'_ str) -> Self {
        Self {
            inner: CLIENT.request(method, url)
        }
    }

    fn body(mut self, b: String) -> Self {
        self.inner = self.inner.body(b);

        self
    }

    fn header<K, V>(mut self, key: K, val: V) -> Self where HeaderName: TryFrom<K>, HeaderValue: TryFrom<V>, <HeaderName as TryFrom<K>>::Error: Into<Error>, <HeaderValue as TryFrom<V>>::Error: Into<Error> {
        self.inner = self.inner.header(key, val);

        self
    }

    fn send(self) -> Result<Self::ReturnValue, Self::Error> {
        Ok(tokio::spawn(async {
             Ok(
                 self.inner
                    .send_with_retry(100, ExponentialBackoff::default()).await?
                    .error_for_status()?
                    .text()
                    .await?
             )
        }))
    }
}

[JakubKoralewski]

I'm not very happy with this signature, as to achieve connection pooling it requires you to use lazy_static type of solution. Ideally I would like to add a third argument to fn new to be able to pass here a reqwest::Client type of variable to clone it for reusing the connection pool. I think adding a third associated type ClientBuilder or sth would be a good idea.

[JakubKoralewski]

Here I added the ability to pass in a client builder:

1e4820f (#1)

I'm not sure if this should be added as for the default case it requries passsing a reference to an empty tuple. This is because lazy_static is being used for the DefaultRequestBuilder anyway.

EDIT : I merged it in.

[JakubKoralewski]

made fn encode public cause I needed it available for my tests

[JakubKoralewski]

sorry I'm piling on like that, this PR is not really a WIP anymore, I'd have opened new PRs if this one got merged

[JakubKoralewski]

Closes #29

[JakubKoralewski]

sorry I'm piling on like that, this PR is not really a WIP anymore, I'd have opened new PRs if this one got merged

now it's ready 😅

[gifnksm]

Thanks for the great pull request.
I would love to merge them.

I've made review comments.
If you have any questions, please feel free to ask.

The source code in the example directory has not been reviewed yet, as it may need to be modified due to changes in src/lib.rs.

[JakubKoralewski]

The examples seem to be failing with a 404 response. I'm not investigating that.

Made changes I found actionable, waiting for response for others.

[gifnksm]

The examples seem to be failing with a 404 response. I'm not investigating that.

I'm going to fix the problem in example, so ignore it.

Made changes I found actionable, waiting for response for others.

I reviewed it again (sorry for being late).
The fix I suggested has been committed to this branch.
You can merge it as it is, or you can modify it.

[JakubKoralewski]

I run miri with the following command cargo test miri parse that ran all the tests involving the parse_query_string function and got no warnings or errors!

[gifnksm]

Thank you!