Skip to content

Commit

Permalink
Add Node 20 and remove 14
Browse files Browse the repository at this point in the history
See https://nodejs.dev/en/about/releases/
for more information.
  • Loading branch information
giggio committed May 2, 2023
1 parent 9f92fba commit 2ea1845
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ RUN echo $USERNAME ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME \
&& chmod 0440 /etc/sudoers.d/$USERNAME
USER $USERNAME
RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.2/install.sh | bash
RUN [ "/bin/bash", "-c", "source $HOME/.nvm/nvm.sh && nvm i --no-progress 14.20.0 && nvm i --no-progress 16.17.1 && nvm i --no-progress 18.11.0 && nvm i --no-progress 19.0.0 " ]
RUN [ "/bin/bash", "-c", "source $HOME/.nvm/nvm.sh && nvm i --no-progress 16.20.0 && nvm i --no-progress 18.16.0 && nvm i --no-progress 19.9.0 && nvm i --no-progress 20.0.0" ]
RUN [ "/bin/bash", "-c", "source $HOME/.nvm/nvm.sh && nvm alias default 19" ]
ENV DEBIAN_FRONTEND=dialog
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ["14.x", "16.x", "18.x", "19.x"]
node: ["16.x", "18.x", "19.x", "20.x"]
runner: ["windows-latest", "ubuntu-latest", "macos-latest"]
steps:
- uses: actions/checkout@v2
Expand Down Expand Up @@ -71,7 +71,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ["14", "16", "18", "19"]
node: ["16", "18", "19", "20"]
steps:
- uses: actions/checkout@v2
- uses: uraimo/run-on-arch-action@v2.1.1
Expand Down Expand Up @@ -122,7 +122,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: 14.x
node-version: 20.x
registry-url: "https://registry.npmjs.org"
- run: |
node --version
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "chromedriver",
"version": "112.0.0",
"version": "112.0.1",
"keywords": [
"chromedriver",
"selenium"
Expand Down Expand Up @@ -41,6 +41,6 @@
"typescript": "^4.9.3"
},
"engines": {
"node": ">=14"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion testInstall.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const os = require('os');
const path = require('path');
const fs = require('fs');
const spawnSync = require('child_process').spawnSync;
const versions = ['14', '16', '18', '19'];
const versions = ['16', '18', '19', '20'];
const tempInstallPath = path.resolve(os.tmpdir(), 'chromedriver-test');
const packedFile = path.resolve(tempInstallPath, 'chromedriver.tgz');

Expand Down

0 comments on commit 2ea1845

Please sign in to comment.