Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for downloading the chromedriver after installation #278

Closed
wants to merge 9 commits into from
Closed

Conversation

r3pwn
Copy link

@r3pwn r3pwn commented Jul 28, 2020

Using the .download async function, we can now do things like

await chromedriver.download();
before any tests get run.

Additionally, some options are supported.
We can pass in download_version or cdn_url like such:
await chromedriver.download({cdn_url: "http://localhost", download_version: 84});

download_version is able to be passed in as the full version of chrome ("84.0.4147.105") or just the major version (84)

I believe this is the functionality requested by @HaimBendanan in issue #256

@r3pwn
Copy link
Author

r3pwn commented Jul 28, 2020

The only additional thing that I think may be beneficial to have as a part of this is an exported is_installed function on lib/chromedriver.js which will allow whoever is using it to see if they need to download chromedriver, or if it's set up properly already, but I will wait for feedback.

@giggio
Copy link
Owner

giggio commented Jul 28, 2020

Wow, this is a large PR, I'll check it out on the weekend.

@r3pwn
Copy link
Author

r3pwn commented Aug 2, 2020

I tested this code using a sample project and adding the following snippet, and it seems to work as intended. Please let me know if you have any questions :)

image

@r3pwn
Copy link
Author

r3pwn commented Aug 8, 2020

@giggio Have you had the chance to look at this PR?

@stale stale bot added the wontfix label Aug 15, 2020
@giggio giggio removed the wontfix label Aug 17, 2020
Repository owner deleted a comment from stale bot Aug 17, 2020
@stale
Copy link

stale bot commented Aug 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 24, 2020
@stale stale bot closed this Aug 31, 2020
@r3pwn
Copy link
Author

r3pwn commented Sep 2, 2020

@giggio Did you ever get a chance to look at this?

@bhuber2010
Copy link

would love to get this merged as well!

@dboterho
Copy link

+1

@github-actions
Copy link

github-actions bot commented Oct 4, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants