Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the SIG prefix is not valid according to the POSIX standard #90

Closed
Asarew opened this issue May 15, 2020 · 8 comments
Closed

the SIG prefix is not valid according to the POSIX standard #90

Asarew opened this issue May 15, 2020 · 8 comments

Comments

@Asarew
Copy link

Asarew commented May 15, 2020

This is the same issue that is discussed here: remy/nodemon#956

@gilamran
Copy link
Owner

You're saying that this: https://github.com/gilamran/tsc-watch/blob/master/lib/killer.js#L5
should change to let KILL_SIGNAL = 'TERM'; ?

@Asarew
Copy link
Author

Asarew commented May 15, 2020

No it should be let KILL_SIGNAL = '15';

@gilamran
Copy link
Owner

gilamran commented May 15, 2020 via email

@Asarew
Copy link
Author

Asarew commented May 15, 2020

No it will have the exact same effect across all Linux distros

@gilamran
Copy link
Owner

Fixed on 4.2.6 (Minor version)
Thanks for the issue!

@Asarew
Copy link
Author

Asarew commented May 18, 2020

No problem, Thanks for the quick support 👍

@Asarew
Copy link
Author

Asarew commented May 18, 2020

Could you make sure that the latest changes are also reflected in the master branch?

@gilamran
Copy link
Owner

sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants