Fix getElementPosition and getScrollTo

- add delayed popper update to fix placement

e2e/__fixtures__/styles.css

@@ -194,3 +194,35 @@ button {
     color: #fff;
   }
 }
+
+.scroll-main {
+  align-items: center;
+  background-color: #ccc;
+  display: flex;
+  flex-direction: column;
+  justify-content: center;
+  min-height: 125vh;
+}
+
+.scroll-title {
+  color: var(--dark-pink);
+  margin: 0 0 32px;
+}
+
+.scroll-subtitle {
+  margin-top: 0;
+}
+
+.scroll-inner-title {
+  margin-top: 0;
+}
+
+.scroll-content {
+  background-color: #fff;
+  height: 50vh;
+  line-height: 1.3;
+  max-width: 800px;
+  margin: 0 auto;
+  padding: 16px;
+  overflow: scroll;
+}

e2e/controlled.spec.tsx

@@ -1,6 +1,7 @@
 /* eslint-disable testing-library/prefer-screen-queries */
 import './global.d';
 
+import React from 'react';
 import { expect, test } from '@playwright/experimental-ct-react';
 
 import { ACTIONS, CallBackProps, EVENTS, LIFECYCLE, STATUS } from '../src';

e2e/scroll.spec.tsx

@@ -0,0 +1,352 @@
+/* eslint-disable testing-library/prefer-screen-queries */
+import './global.d';
+
+import React from 'react';
+import { sleep } from '@gilbarbara/helpers';
+import { expect, test } from '@playwright/experimental-ct-react';
+
+import { ACTIONS, CallBackProps, EVENTS, LIFECYCLE, STATUS } from '../src';
+import Scroll from '../test/__fixtures__/Scroll';
+
+function formatCallbackResponse(input: Partial<CallBackProps>) {
+  return {
+    controlled: false,
+    size: 5,
+    status: STATUS.RUNNING,
+    ...input,
+  };
+}
+
+test.use({ viewport: { width: 1024, height: 768 } });
+
+test('should run the tour', async ({ mount, page }) => {
+  const callback: Array<any> = [];
+
+  const getScrollTop = async () => {
+    const scrollingElementHandle = await page.evaluateHandle(() =>
+      Promise.resolve(document.querySelector('.scroll-content')?.scrollTop),
+    );
+    const value = scrollingElementHandle.jsonValue();
+
+    await scrollingElementHandle.dispose();
+
+    return value;
+  };
+
+  await mount(
+    <Scroll
+      callback={({ step, ...rest }) => {
+        callback.push(rest);
+      }}
+    />,
+  );
+
+  await page.evaluate(() => window.scrollTo(0, document.body.scrollHeight));
+  await expect(page).toHaveScreenshot('step1-beacon.png');
+  await expect.poll(() => callback.length).toBe(3);
+
+  expect(callback[0]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.START,
+      index: 0,
+      lifecycle: LIFECYCLE.INIT,
+      type: EVENTS.TOUR_START,
+    }),
+  );
+
+  expect(callback[1]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.START,
+      index: 0,
+      lifecycle: LIFECYCLE.READY,
+      type: EVENTS.STEP_BEFORE,
+    }),
+  );
+
+  expect(callback[2]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.UPDATE,
+      index: 0,
+      lifecycle: LIFECYCLE.BEACON,
+      type: EVENTS.BEACON,
+    }),
+  );
+
+  // First step
+  await page.getByTestId('button-beacon').click();
+
+  expect(callback[3]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.UPDATE,
+      index: 0,
+      lifecycle: LIFECYCLE.TOOLTIP,
+      type: EVENTS.TOOLTIP,
+    }),
+  );
+
+  await sleep(1);
+  await expect(page).toHaveScreenshot('step1-tooltip.png');
+  await expect.poll(getScrollTop).toBeAround(0);
+
+  await page.getByTestId('button-primary').click();
+
+  await expect.poll(() => callback.length).toBe(7);
+
+  expect(callback[4]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.NEXT,
+      index: 0,
+      lifecycle: LIFECYCLE.COMPLETE,
+      type: EVENTS.STEP_AFTER,
+    }),
+  );
+
+  // Second step
+  await sleep(1);
+  await expect(page).toHaveScreenshot('step2-tooltip.png');
+  await expect.poll(getScrollTop).toBeAround(0);
+
+  expect(callback[5]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.NEXT,
+      index: 1,
+      lifecycle: LIFECYCLE.READY,
+      type: EVENTS.STEP_BEFORE,
+    }),
+  );
+
+  expect(callback[6]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.UPDATE,
+      index: 1,
+      lifecycle: LIFECYCLE.TOOLTIP,
+      type: EVENTS.TOOLTIP,
+    }),
+  );
+
+  await page.getByTestId('button-primary').click();
+
+  await expect.poll(() => callback.length).toBe(10);
+
+  expect(callback[7]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.NEXT,
+      index: 1,
+      lifecycle: LIFECYCLE.COMPLETE,
+      type: EVENTS.STEP_AFTER,
+    }),
+  );
+
+  // Third step
+  await sleep(1);
+  await expect(page).toHaveScreenshot('step3-tooltip.png');
+  await expect.poll(getScrollTop).toBeAround(249, 25);
+
+  expect(callback[8]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.NEXT,
+      index: 2,
+      lifecycle: LIFECYCLE.READY,
+      type: EVENTS.STEP_BEFORE,
+    }),
+  );
+
+  expect(callback[9]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.UPDATE,
+      index: 2,
+      lifecycle: LIFECYCLE.TOOLTIP,
+      type: EVENTS.TOOLTIP,
+    }),
+  );
+
+  await page.getByTestId('button-primary').click();
+
+  await expect.poll(() => callback.length).toBe(13);
+
+  expect(callback[10]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.NEXT,
+      index: 2,
+      lifecycle: LIFECYCLE.COMPLETE,
+      type: EVENTS.STEP_AFTER,
+    }),
+  );
+
+  // Fourth step
+  await sleep(1);
+  await expect(page).toHaveScreenshot('step4-tooltip.png');
+  await expect.poll(getScrollTop).toBeAround(412, 25);
+
+  expect(callback[11]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.NEXT,
+      index: 3,
+      lifecycle: LIFECYCLE.READY,
+      type: EVENTS.STEP_BEFORE,
+    }),
+  );
+
+  expect(callback[12]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.UPDATE,
+      index: 3,
+      lifecycle: LIFECYCLE.TOOLTIP,
+      type: EVENTS.TOOLTIP,
+    }),
+  );
+
+  await page.getByTestId('button-back').click();
+
+  await expect.poll(() => callback.length).toBe(16);
+
+  expect(callback[13]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.PREV,
+      index: 3,
+      lifecycle: LIFECYCLE.COMPLETE,
+      type: EVENTS.STEP_AFTER,
+    }),
+  );
+
+  // Back to the third step
+  await sleep(1);
+  await expect(page).toHaveScreenshot('step3-tooltip-back.png');
+  await expect.poll(getScrollTop).toBeAround(249, 25);
+
+  expect(callback[14]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.PREV,
+      index: 2,
+      lifecycle: LIFECYCLE.READY,
+      type: EVENTS.STEP_BEFORE,
+    }),
+  );
+
+  expect(callback[15]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.UPDATE,
+      index: 2,
+      lifecycle: LIFECYCLE.TOOLTIP,
+      type: EVENTS.TOOLTIP,
+    }),
+  );
+
+  await page.getByTestId('button-primary').click();
+
+  await expect.poll(() => callback.length).toBe(19);
+
+  expect(callback[16]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.NEXT,
+      index: 2,
+      lifecycle: LIFECYCLE.COMPLETE,
+      type: EVENTS.STEP_AFTER,
+    }),
+  );
+
+  // go to the fourth step again
+  await sleep(1);
+  await expect(page).toHaveScreenshot('step4-tooltip-forward.png');
+  await expect.poll(getScrollTop).toBeAround(412, 25);
+
+  expect(callback[17]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.NEXT,
+      index: 3,
+      lifecycle: LIFECYCLE.READY,
+      type: EVENTS.STEP_BEFORE,
+    }),
+  );
+
+  expect(callback[18]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.UPDATE,
+      index: 3,
+      lifecycle: LIFECYCLE.TOOLTIP,
+      type: EVENTS.TOOLTIP,
+    }),
+  );
+
+  await page.getByTestId('button-primary').click();
+
+  await expect.poll(() => callback.length).toBe(22);
+
+  expect(callback[19]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.NEXT,
+      index: 3,
+      lifecycle: LIFECYCLE.COMPLETE,
+      status: STATUS.RUNNING,
+      type: EVENTS.STEP_AFTER,
+    }),
+  );
+
+  // Fifth step
+  await sleep(1);
+  await expect(page).toHaveScreenshot('step5-tooltip.png');
+  await expect.poll(getScrollTop).toBeAround(696, 25);
+
+  expect(callback[20]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.NEXT,
+      index: 4,
+      lifecycle: LIFECYCLE.READY,
+      type: EVENTS.STEP_BEFORE,
+    }),
+  );
+
+  expect(callback[21]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.UPDATE,
+      index: 4,
+      lifecycle: LIFECYCLE.TOOLTIP,
+      type: EVENTS.TOOLTIP,
+    }),
+  );
+
+  // Finish the tour
+  await page.getByTestId('button-primary').click();
+
+  await expect.poll(() => callback.length).toBe(26);
+
+  expect(callback[22]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.NEXT,
+      index: 4,
+      lifecycle: LIFECYCLE.COMPLETE,
+      status: STATUS.FINISHED,
+      type: EVENTS.STEP_AFTER,
+    }),
+  );
+
+  expect(callback[23]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.NEXT,
+      index: 4,
+      lifecycle: LIFECYCLE.INIT,
+      status: STATUS.FINISHED,
+      type: EVENTS.TOUR_END,
+    }),
+  );
+
+  expect(callback[24]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.RESET,
+      index: 0,
+      lifecycle: LIFECYCLE.INIT,
+      status: STATUS.READY,
+      type: EVENTS.TOUR_STATUS,
+    }),
+  );
+
+  expect(callback[25]).toEqual(
+    formatCallbackResponse({
+      action: ACTIONS.STOP,
+      index: 0,
+      lifecycle: LIFECYCLE.INIT,
+      status: STATUS.PAUSED,
+      type: EVENTS.TOUR_STATUS,
+    }),
+  );
+});