Support ignoring Language Encoding flag #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree that this option is useful, especially in the case you mentioned. The name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on a tool which has to generate ZIP files reproducibly and I had to make it backwards compatible with an older version of the tool written in Rust.
The files generated by the Rust-based tool have:
The ones generated by zip.js have:
I saw that in
zip-writer.jsthe language encoding bit was always set to 1. I chose to add a new option calleduseUnicodeFileNamesto disable this flag. I made the flag true by default to avoid any backward compatibility issues.Not sure if the name is very appropriate since it implies more than just setting a flag in the header, so I'm open to suggestions. I thought of
includeLanguageEncodingHeader, but I thought it's too technical.Additionally, I see some discussions were held regarding UTF-8 handling of file names in #131 but for reading and not writing.