Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouped bar chart graph #325

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Grouped bar chart graph #325

merged 2 commits into from
Aug 6, 2024

Conversation

marxin
Copy link
Contributor

@marxin marxin commented Aug 5, 2024

The graph is based on the following example: https://matplotlib.org/stable/gallery/lines_bars_and_markers/barchart.html#sphx-glr-gallery-lines-bars-and-markers-barchart-py.

Apparently, we can use vector images in the README page, yay!

@marxin marxin force-pushed the improve-graph branch 2 times, most recently from de040f7 to 534d1c6 Compare August 5, 2024 05:21
Copy link
Contributor

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, bars look much better.

scripts/benchmark-plot.py Outdated Show resolved Hide resolved
scripts/benchmark-plot.py Outdated Show resolved Hide resolved
scripts/benchmark-plot.py Outdated Show resolved Hide resolved
scripts/benchmark-plot.py Outdated Show resolved Hide resolved
@marxin
Copy link
Contributor Author

marxin commented Aug 5, 2024

I addressed all your comments, they were beneficial!

Note I also formatted the code with ruff tool.

@marxin marxin requested a review from philipc August 5, 2024 09:38
scripts/benchmark-plot.py Outdated Show resolved Hide resolved
Co-authored-by: Philip Craig <philipjcraig@gmail.com>
@philipc philipc merged commit 48f4734 into gimli-rs:master Aug 6, 2024
12 checks passed
@marxin marxin deleted the improve-graph branch August 6, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants