Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
struct Register(u16)
.u16
is chosen because the ARM ABI specifies values larger than 256. Replace all register usage with the newtype. Previously we usedu8
for CFI andu64
for expressions.Add constants for X86/X86-64 and some ARM registers. Add
register_name
methods. These are defined within empty structs rather than modules. This gives us the option in future of implementing a trait for these structs (egregister_name
may make sense as a trait method, and maybe things like afn sp() -> Register
, although that may be better in the unwinder).Update dwarfdump to use the register names when dumping
.eh_frame
(but not expressions because they usually have register specific opcodes rather than register numbers).Fixes #200