Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detection of same origin is broken #60

Closed
ReneGa opened this issue Dec 6, 2019 · 0 comments · Fixed by #61
Closed

Detection of same origin is broken #60

ReneGa opened this issue Dec 6, 2019 · 0 comments · Fixed by #61

Comments

@ReneGa
Copy link
Contributor

ReneGa commented Dec 6, 2019 •
edited
Loading

When AllowAllOrigins is set to false, a request with same origin and host should not be subject to the AllowOrigins-check.
@ReneGa ReneGa mentioned this issue Dec 6, 2019
Merged
appleboy pushed a commit that referenced this issue Mar 6, 2020
@ReneGa
Fix detection of same origin (#61)
3ce2e80 
For incoming requests, the Host header is promoted to the
Request.Host field and removed from the Header map.

Therefore, it is Request.Host that needs to be compared against
the origin of a request.

Fixes: #60
@dbhoot dbhoot mentioned this issue Feb 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix detection of same origin
1 participant
@ReneGa