Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Status method to Writer struct and update test #63

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

appleboy
Copy link
Member

@appleboy appleboy commented Nov 25, 2023

  • Add a Status method to the Writer struct
  • Modify the TestWriter_Status test function to include the new Status method

fixed by @zhyee

fixed #52
fixed #51

- Add a `Status` method to the `Writer` struct
- Modify the `TestWriter_Status` test function to include the new `Status` method

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f2805fd) 94.91% compared to head (1f61d12) 92.68%.

Files Patch % Lines
writer.go 40.00% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   94.91%   92.68%   -2.24%     
==========================================
  Files           4        4              
  Lines         118      123       +5     
==========================================
+ Hits          112      114       +2     
- Misses          4        6       +2     
- Partials        2        3       +1     
Flag Coverage Δ
go- 92.68% <40.00%> (-2.24%) ⬇️
go-1.18 92.68% <40.00%> (-2.24%) ⬇️
go-1.19 87.80% <40.00%> (-2.03%) ⬇️
go-1.20 92.68% <40.00%> (-2.24%) ⬇️
go-1.21 92.68% <40.00%> (+0.31%) ⬆️
macos-latest 92.68% <40.00%> (-2.24%) ⬇️
ubuntu-latest 92.68% <40.00%> (-2.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@appleboy appleboy merged commit 7452411 into master Nov 25, 2023
8 checks passed
@appleboy appleboy deleted the timeout2 branch November 25, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants