Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update comment #1057

Merged
merged 2 commits into from
Aug 16, 2017
Merged

update comment #1057

merged 2 commits into from
Aug 16, 2017

Conversation

thinkerou
Copy link
Member

@thinkerou thinkerou commented Aug 8, 2017

Comments should begin with the name of the thing being described and end in a period, from:
https://github.com/golang/go/wiki/CodeReviewComments#comment-sentences

@codecov
Copy link

codecov bot commented Aug 11, 2017

Codecov Report

Merging #1057 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1057   +/-   ##
=======================================
  Coverage   96.66%   96.66%           
=======================================
  Files          16       16           
  Lines        1711     1711           
=======================================
  Hits         1654     1654           
  Misses         49       49           
  Partials        8        8
Impacted Files Coverage Δ
gin.go 92.2% <ø> (ø) ⬆️
auth.go 100% <ø> (ø) ⬆️
recovery.go 90.62% <ø> (ø) ⬆️
tree.go 100% <ø> (ø) ⬆️
response_writer.go 100% <ø> (ø) ⬆️
path.go 100% <ø> (ø) ⬆️
utils.go 90.72% <ø> (ø) ⬆️
fs.go 100% <ø> (ø) ⬆️
context.go 96.61% <ø> (ø) ⬆️
logger.go 100% <ø> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecae34c...45869f9. Read the comment docs.

@appleboy appleboy merged commit a8fa424 into gin-gonic:master Aug 16, 2017
@thinkerou thinkerou deleted the comment branch August 22, 2017 05:58
@javierprovecho javierprovecho added this to the 1.3 milestone Aug 26, 2017
tonyhhyip pushed a commit to ysitd-cloud/gin that referenced this pull request Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants