-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some test cases and run test cases on binding/render dir #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1168 +/- ##
=========================================
+ Coverage 98.18% 98.4% +0.22%
=========================================
Files 16 34 +18
Lines 1432 1757 +325
=========================================
+ Hits 1406 1729 +323
- Misses 22 23 +1
- Partials 4 5 +1
Continue to review full report at Codecov.
|
1 task
…es for binding and render
squash commits and reopen the pull request. |
thinkerou
changed the title
add go test sub-dir
Travis run test cases on binding and render dir and add some test cases for binding and render
Nov 16, 2017
thinkerou
changed the title
Travis run test cases on binding and render dir and add some test cases for binding and render
Add some test cases and run test cases on binding/render dir
Nov 18, 2017
appleboy
approved these changes
Jan 26, 2018
@thinkerou Thanks. |
tonyhhyip
pushed a commit
to ysitd-cloud/gin
that referenced
this pull request
Feb 20, 2018
…ic#1168) * Travis run test cases on binding and render dir and add some test cases for binding and render
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now travis not run some test cases on
binding
andrender
dir.Hi, @javierprovecho @appleboy @tboerger should we add these test case?
Thanks!
The pull request includes the follow points:
Makefile
for runningcoverage.sh
coverage.sh
to run code coverage raterender
andbinding
tocoverage.sh
binding_test.go
which code coverage rate is99.23%
render_test.go
which code coverage rate is100%
.gitignore