Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some test cases and run test cases on binding/render dir #1168

Merged
merged 13 commits into from
Jan 26, 2018
Merged

Add some test cases and run test cases on binding/render dir #1168

merged 13 commits into from
Jan 26, 2018

Conversation

thinkerou
Copy link
Member

@thinkerou thinkerou commented Nov 12, 2017

Now travis not run some test cases on binding and render dir.
Hi, @javierprovecho @appleboy @tboerger should we add these test case?
Thanks!
The pull request includes the follow points:

  • update Makefile for running coverage.sh
  • add coverage.sh to run code coverage rate
  • add render and binding to coverage.sh
  • update binding_test.go which code coverage rate is 99.23%
  • update render_test.go which code coverage rate is 100%
  • update .gitignore

@codecov
Copy link

codecov bot commented Nov 12, 2017

Codecov Report

Merging #1168 into master will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1168      +/-   ##
=========================================
+ Coverage   98.18%   98.4%   +0.22%     
=========================================
  Files          16      34      +18     
  Lines        1432    1757     +325     
=========================================
+ Hits         1406    1729     +323     
- Misses         22      23       +1     
- Partials        4       5       +1
Impacted Files Coverage Δ
binding/binding.go 100% <0%> (ø)
render/html.go 100% <0%> (ø)
render/text.go 100% <0%> (ø)
binding/xml.go 100% <0%> (ø)
binding/form_mapping.go 98.29% <0%> (ø)
render/render.go 100% <0%> (ø)
binding/query.go 100% <0%> (ø)
render/msgpack.go 100% <0%> (ø)
render/data.go 100% <0%> (ø)
binding/msgpack.go 100% <0%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fbb971...cba8682. Read the comment docs.

@thinkerou thinkerou mentioned this pull request Nov 12, 2017
1 task
@thinkerou thinkerou closed this Nov 13, 2017
@thinkerou thinkerou reopened this Nov 13, 2017
@thinkerou thinkerou closed this Nov 13, 2017
@thinkerou thinkerou reopened this Nov 13, 2017
@thinkerou thinkerou closed this Nov 16, 2017
@thinkerou
Copy link
Member Author

squash commits and reopen the pull request.

@thinkerou thinkerou reopened this Nov 16, 2017
@thinkerou thinkerou changed the title add go test sub-dir Travis run test cases on binding and render dir and add some test cases for binding and render Nov 16, 2017
@thinkerou thinkerou changed the title Travis run test cases on binding and render dir and add some test cases for binding and render Add some test cases and run test cases on binding/render dir Nov 18, 2017
@appleboy appleboy merged commit 783c7ee into gin-gonic:master Jan 26, 2018
@appleboy
Copy link
Member

@thinkerou Thanks.

tonyhhyip pushed a commit to ysitd-cloud/gin that referenced this pull request Feb 20, 2018
…ic#1168)

* Travis run test cases on binding and render dir and add some test cases for binding and render
@thinkerou thinkerou deleted the add-test branch April 20, 2018 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants