Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix StaticFS() get "index out of range" if file not found (#1678) #1716

Closed
wants to merge 0 commits into from

Conversation

vkd
Copy link
Contributor

@vkd vkd commented Dec 26, 2018

Fixing #1678

We cannot rewrite c.handlers in handler during iterate over it on c.Next(...)

@codecov
Copy link

codecov bot commented Dec 26, 2018

Codecov Report

Merging #1716 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1716      +/-   ##
=========================================
- Coverage    99.4%   99.4%   -0.01%     
=========================================
  Files          42      42              
  Lines        2029    2027       -2     
=========================================
- Hits         2017    2015       -2     
  Misses          9       9              
  Partials        3       3
Impacted Files Coverage Δ
routergroup.go 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bfc9cb...bee4ee6. Read the comment docs.

@thinkerou
Copy link
Member

thinkerou commented Dec 26, 2018

revert #1663 ?
cc @MetalBreaker

@ilijaivanov
Copy link
Contributor

ilijaivanov commented Dec 26, 2018

I don't use Gin anymore. Do whatever you have to.
I personally didn't have an issue with this. Maybe something major got rewritten that slipped past me. Just saying that this prevents a real use case - serving a "file not found" HTML page instead of ugly "404 not found" text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants