Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spell check #1796

Merged
merged 4 commits into from
Mar 5, 2019
Merged

spell check #1796

merged 4 commits into from
Mar 5, 2019

Conversation

wybcp
Copy link
Contributor

@wybcp wybcp commented Mar 5, 2019

  • spell check
  • variable should be little camel-case
  • variable path collides with imported package name,avoid to use it

@thinkerou thinkerou added this to the 1.4 milestone Mar 5, 2019
wybcp
wybcp commented Mar 5, 2019
View reviewed changes
Copy link
Contributor Author

@wybcp wybcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • spell check
  • variable should be little camel-case
  • variable path collides with imported package name,avoid to use it

@codecov
Copy link

codecov bot commented Mar 5, 2019 •
edited
Loading

Codecov Report

Merging #1796 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1796   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          41       41           
  Lines        2112     2112           
=======================================
  Hits         2083     2083           
  Misses         18       18           
  Partials       11       11
Impacted Files Coverage Δ
errors.go 100% <ø> (ø) ⬆️
recovery.go 100% <100%> (ø) ⬆️
gin.go 99.1% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5dda62...b58a472. Read the comment docs.

thinkerou
thinkerou approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thinkerou thinkerou merged commit 057f63b into gin-gonic:master Mar 5, 2019
wybcp added a commit to wybcp/gin that referenced this pull request Mar 7, 2019
@wybcp
Merge branch 'master' into riverside-master
0850387 
* master:
  make context.Keys available as LogFormatterParams (gin-gonic#1779)
  spell check  (gin-gonic#1796)
  chore: use internal/json (gin-gonic#1791)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkerou thinkerou thinkerou approved these changes

@javierprovecho javierprovecho Awaiting requested review from javierprovecho

@appleboy appleboy Awaiting requested review from appleboy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@wybcp @thinkerou