-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modular deps for binding and render #1856
base: master
Are you sure you want to change the base?
Conversation
For details:
|
Codecov Report
@@ Coverage Diff @@
## master #1856 +/- ##
==========================================
+ Coverage 98.65% 99.14% +0.49%
==========================================
Files 41 30 -11
Lines 2149 1991 -158
==========================================
- Hits 2120 1974 -146
+ Misses 18 11 -7
+ Partials 11 6 -5
Continue to review full report at Codecov.
|
4f66657
to
e472164
Compare
@sapk 👏
I kinda like the way this feels only opting into what you want really nice 👍
I do like the idea of the "builtins" being there by default. But would that allow the user to replace the xml/json with a different (faster) binding/render for json/xml if we are including it by default? I'm really interested in the core teams thoughts on this idea is! 👍 on the user's interface. If everyone likes this direction have a few chores like Docs, examples, benchmark, alloc's, etc. |
@dmarkham Yes you can load a module that fill the same id in the respective common List to be call in place of the gin one. |
any update discuss? |
Following the similar pattern as sql drivers.
I extract xml, json, msgpack, protobuf and yaml into separate module.
This PR may break compat with previous versions.
For example: https://github.com/sapk-fork/gin-examples/blob/test-modular/basic/main.go
I think we can maybe re-add json and xml as default.
Related #1847 (issue) & #1852 (previous non-breaking solution)