-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix form binding with json custom type that underling form is string(#2510) #2511
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2511 +/- ##
=======================================
Coverage 98.45% 98.46%
=======================================
Files 41 41
Lines 1948 1952 +4
=======================================
+ Hits 1918 1922 +4
Misses 17 17
Partials 13 13 ☔ View full report in Codecov by Sentry. |
@LaysDragon thanks, please add unit test. |
123aaf5
to
c9169b0
Compare
ok,I add it. And wrap two error together if second time try parse still failed. |
and add test
|
Any update on this? |
What it solves
Current form binding will failed if custom struct type that underling is string with json.Unmarshal . detail see #2510
It will trying to Unmarshal the value with quoted again to fix this issue.