Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix form binding with json custom type that underling form is string(#2510) #2511

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LaysDragon
Copy link

What it solves

Current form binding will failed if custom struct type that underling is string with json.Unmarshal . detail see #2510
It will trying to Unmarshal the value with quoted again to fix this issue.

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (540b1ef) to head (e425b26).
Report is 385 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2511   +/-   ##
=======================================
  Coverage   98.45%   98.46%           
=======================================
  Files          41       41           
  Lines        1948     1952    +4     
=======================================
+ Hits         1918     1922    +4     
  Misses         17       17           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thinkerou
Copy link
Member

@LaysDragon thanks, please add unit test.

@LaysDragon
Copy link
Author

ok,I add it. And wrap two error together if second time try parse still failed.
well that the problem go 1.11 doesn't have error wrap...

@LaysDragon
Copy link
Author

LaysDragon commented Sep 28, 2020

@LaysDragon thanks, please add unit test.
ok it done

@eloyekunle
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants