Require C++17 support #1603

upsj · 2024-05-01T13:34:09Z

This requires C++17 support and removes the workarounds we had in place before

upsj · 2024-05-01T13:38:46Z

This also means bumping GCC to version 7, Clang to version 5 and CUDA to version 11

include/ginkgo/core/log/profiler_hook.hpp

README.md

yhmtsai

another question: Maybe I miss the discussion, do we drop the cuda 10.1/10.2 support?

.gitlab-ci.yml

yhmtsai · 2024-06-28T08:50:02Z

.gitlab-ci.yml

@@ -291,40 +159,6 @@ test/cuda110/nompi/clang/cuda/release/static:
  needs: [ "build/cuda110/nompi/clang/cuda/release/static" ]


-build/cuda110/nompi/intel/cuda/debug/static:


why is it removed?

nvcc with icpc as the host compiler can't compile a simple C++17 header like <variant>, so I would say that qualifies as not properly supporting C++17, see https://gitlab.com/ginkgo-project/ginkgo-public-ci/-/jobs/7265870465

README.md

yhmtsai · 2024-06-28T08:57:26Z

core/test/accessor/CMakeLists.txt

-    target_compile_features("${TEST_TARGET_NAME}" PUBLIC cxx_std_14)
+    target_compile_features("${TEST_TARGET_NAME}" PUBLIC cxx_std_17)


only this changes from 14 to 17, but others are just removed.

the others are all implied by the PUBLIC property on the ginkgo target

thoasm

Please also change the include/ginkgo/core/base/std_extensions.hpp (for example, remove the make_void and change the implementation of uncaught_exception()).
I would also like to know why the tests/pipelines were dropped.

examples/custom-matrix-format/CMakeLists.txt

upsj · 2024-07-04T11:49:11Z

@thoasm changes in std_extensions would technically break interface, so I wanted to avoid them

thoasm · 2024-07-05T09:17:59Z

@upsj I'm not suggesting to drop the functions/structures completely, but you can implement xstd.:uncaught_exception with std::uncaught_exception. The same with xstd.:void_t. We did this for all the other members of the xstd namespace.
The make_void helper I was talking about is in detail, so dropping it is fine.

thoasm

LGTM!

yhmtsai

Because it removes the check for cuda_arch 35, need to add this back to other jobs.
I think setting the standard through the property is more clear.
For example, hip_std_17 is not searchable in cmake 3.21.7 (the minimal requirement for hip module).

cmake/build_helpers.cmake

yhmtsai

only needs some tests for cuda arch 35

ginkgo has the PUBLIC property cxx_std_17, so we don't need to set it in tests. pkg-config doesn't propagate C++ standards

nvcc with clang++ host compiler seems incompatible with libstdc++-10

upsj · 2024-07-08T19:30:38Z

@yhmtsai I needed to add a new pipeline, since all remaining ones both build and test, so they are restricted to our available GPUs. compute capabilities 3.5 - 5.0 have been deprecated in CUDA 11, so I'm using 5.2 for the build. We don't have any GPUs below compute capability 6.0 anyways.

sonarqubecloud · 2024-07-09T04:27:56Z

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

This requires the compilers to support C++17 and removes no longer necessary workarounds. Related PR: ginkgo-project#1603

upsj added the 1:ST:ready-for-review This PR is ready for review label May 1, 2024

upsj requested a review from a team May 1, 2024 13:34

upsj self-assigned this May 1, 2024

upsj added the 1:ST:run-full-test label May 1, 2024

upsj force-pushed the c++17 branch from 497c779 to b61c0a8 Compare May 1, 2024 15:25

This was referenced May 1, 2024

Allow zip_iterator to be used on the device #1604

Merged

Simple segmented ranges #1601

Merged

tcojean added this to the Ginkgo 1.9.0 milestone May 3, 2024

MarcelKoch requested changes Jun 14, 2024

View reviewed changes

include/ginkgo/core/log/profiler_hook.hpp Show resolved Hide resolved

README.md Show resolved Hide resolved

MarcelKoch mentioned this pull request Jun 27, 2024

Adds (S)SOR Preconditioner #1633

Merged

2 tasks

yhmtsai requested changes Jun 28, 2024

View reviewed changes

thoasm requested changes Jul 2, 2024

View reviewed changes

examples/custom-matrix-format/CMakeLists.txt Outdated Show resolved Hide resolved

upsj force-pushed the c++17 branch from b61c0a8 to c5336b5 Compare July 4, 2024 11:58

upsj force-pushed the c++17 branch 2 times, most recently from 4fc0bce to b59f135 Compare July 5, 2024 10:36

upsj requested review from MarcelKoch, thoasm and yhmtsai July 5, 2024 10:36

MarcelKoch approved these changes Jul 5, 2024

View reviewed changes

thoasm approved these changes Jul 8, 2024

View reviewed changes

yhmtsai reviewed Jul 8, 2024

View reviewed changes

cmake/build_helpers.cmake Show resolved Hide resolved

yhmtsai approved these changes Jul 8, 2024

View reviewed changes

upsj added 11 commits July 8, 2024 15:17

require C++17 support

fc5b5af

adress TODOs

bd2ccae

add missing include

29666a4

set C++ version where necessary, remove checks where unnecessary

38388eb

ginkgo has the PUBLIC property cxx_std_17, so we don't need to set it in tests. pkg-config doesn't propagate C++ standards

remove unsupported compilers

718a42d

use compile features for specifying HIP/CUDA standard version

1115805

update version requirements

763b637

remove older std_extensions

b17b01a

remove unsupported Intel + CUDA build

f63f622

review updates and formatting

bc6ff65

add build-only job for SM 3.5

1334ea7

upsj force-pushed the c++17 branch from b59f135 to 1334ea7 Compare July 8, 2024 13:17

upsj added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Jul 8, 2024

upsj added 2 commits July 8, 2024 16:48

remove warning flags

4cc9249

move to a compatible nvcc/clang combination

f570559

nvcc with clang++ host compiler seems incompatible with libstdc++-10

upsj merged commit caa373d into develop Jul 8, 2024
12 of 14 checks passed

upsj deleted the c++17 branch July 8, 2024 22:04

nbeams mentioned this pull request Aug 15, 2024

Update C++ standard to C++17 when building with Ginkgo mfem/mfem#4452

Open

61 tasks

MarcelKoch pushed a commit to MarcelKoch/ginkgo that referenced this pull request Dec 2, 2024

Merge C++17 requirement

a72d217

This requires the compilers to support C++17 and removes no longer necessary workarounds. Related PR: ginkgo-project#1603

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Require C++17 support #1603

Require C++17 support #1603

upsj commented May 1, 2024

upsj commented May 1, 2024

yhmtsai left a comment

yhmtsai Jun 28, 2024

upsj Jul 4, 2024 •

edited

Loading

yhmtsai Jun 28, 2024

upsj Jun 28, 2024

thoasm left a comment

upsj commented Jul 4, 2024

thoasm commented Jul 5, 2024

thoasm left a comment

yhmtsai left a comment

yhmtsai left a comment

upsj commented Jul 8, 2024

sonarqubecloud bot commented Jul 9, 2024

		@@ -291,40 +159,6 @@ test/cuda110/nompi/clang/cuda/release/static:
		needs: [ "build/cuda110/nompi/clang/cuda/release/static" ]


		build/cuda110/nompi/intel/cuda/debug/static:

		target_compile_features("${TEST_TARGET_NAME}" PUBLIC cxx_std_14)
		target_compile_features("${TEST_TARGET_NAME}" PUBLIC cxx_std_17)

Require C++17 support #1603

Require C++17 support #1603

Conversation

upsj commented May 1, 2024

upsj commented May 1, 2024

yhmtsai left a comment

Choose a reason for hiding this comment

yhmtsai Jun 28, 2024

Choose a reason for hiding this comment

upsj Jul 4, 2024 • edited Loading

Choose a reason for hiding this comment

yhmtsai Jun 28, 2024

Choose a reason for hiding this comment

upsj Jun 28, 2024

Choose a reason for hiding this comment

thoasm left a comment

Choose a reason for hiding this comment

upsj commented Jul 4, 2024

thoasm commented Jul 5, 2024

thoasm left a comment

Choose a reason for hiding this comment

yhmtsai left a comment

Choose a reason for hiding this comment

yhmtsai left a comment

Choose a reason for hiding this comment

upsj commented Jul 8, 2024

sonarqubecloud bot commented Jul 9, 2024

Quality Gate failed

upsj Jul 4, 2024 •

edited

Loading