Add Sor kernels #1634
Add Sor kernels #1634
Conversation
ginkgo-bot
added
reg:build
MarcelKoch
force-pushed
the
sor-kernels
branch
2 times, most recently
from
0d29fae
to
1f1ef07
Compare
MarcelKoch
force-pushed
the
sor-kernels
branch
2 times, most recently
from
a94cab2
to
7c59123
Compare
MarcelKoch
force-pushed
the
sor-kernels
branch
3 times, most recently
from
a30fee7
to
79ed6d7
Compare
| namespace factorization { | ||
| namespace helpers { | ||
|
|
||
| using namespace ::gko::factorization; |
There was a problem hiding this comment.
it does not help anything below, so I would rather remove it.
There was a problem hiding this comment.
To make this more reasonable, I also removed the factorization namespace in the core file. Otherwise I would have had to use ::gko::factorization:: everywhere instead of just helpers::.
There was a problem hiding this comment.
sorry, I thought they are in the same namespace, but one is under kernel namespace and the other is under gko directly.
then the original one is better as it does not give any ambiguous function.
although it can only declare the two class you need, it's a bit annoying with the template.
| namespace helpers { | ||
|
|
||
|
|
||
| using namespace ::gko::factorization; |
| @@ -0,0 +1,67 @@ | |||
| // SPDX-FileCopyrightText: 2017 - 2024 The Ginkgo authors | |||
There was a problem hiding this comment.
I think the file can go into unified one but you need to do dispatch on the header of factorization_helpers.hpp
There was a problem hiding this comment.
you may need to use GKO_KERNEL for the lambda function.
Maybe also for the actual kernel?
There was a problem hiding this comment.
I feel like this complicates our unified setup again, and it's not using the unified kernels as intended.
We use the unified kernels, when the kernel implementation are identical, which is not the case here. I think it's close, but it would require some adjustments of the factorization kernels. If that's feasible, I would prefer to do it in another PR.
- formatting - remove inline namespace Co-authored-by: Yu-Hsiang M. Tsai <yhmtsai@gmail.com>
| } // namespace factorization | ||
| } // namespace GKO_DEVICE_NAMESPACE | ||
| } // namespace kernels | ||
| } // namespace gko |
There was a problem hiding this comment.
| } // namespace gko | |
| } // namespace gko | |
nit
| namespace factorization { | ||
| namespace helpers { | ||
|
|
||
| using namespace ::gko::factorization; |
There was a problem hiding this comment.
sorry, I thought they are in the same namespace, but one is under kernel namespace and the other is under gko directly.
then the original one is better as it does not give any ambiguous function.
although it can only declare the two class you need, it's a bit annoying with the template.
This PR adds the device kernels for #1633.